diff options
author | Harald Musum <musum@verizonmedia.com> | 2020-02-12 13:32:53 +0100 |
---|---|---|
committer | Harald Musum <musum@verizonmedia.com> | 2020-02-12 13:32:53 +0100 |
commit | 2110582befb0b8401c8d887d44947d5bdbd45630 (patch) | |
tree | a4d1aef51bbcebfb86ccf196f302cbb3ec24d7f8 /config | |
parent | 9dbfbde6b3dd1f3f1e10509b6193617a45e38119 (diff) |
Remove constructor only used in tests
Diffstat (limited to 'config')
-rw-r--r-- | config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java | 4 | ||||
-rw-r--r-- | config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java | 16 |
2 files changed, 10 insertions, 10 deletions
diff --git a/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java b/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java index 324546230d9..b2a089c3885 100644 --- a/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java +++ b/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java @@ -32,10 +32,6 @@ public class GenericConfigSubscriber extends ConfigSubscriber { this.requesters = requesters; } - public GenericConfigSubscriber() { - super(); - } - /** * Subscribes to config without using the class. For internal use in config proxy. * diff --git a/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java b/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java index 39d40aea3ac..e9dc9cf7b98 100644 --- a/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java +++ b/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java @@ -61,19 +61,23 @@ public class GenericConfigSubscriberTest { @Test(expected=UnsupportedOperationException.class) public void testOverriddenSubscribeInvalid1() { - GenericConfigSubscriber sub = new GenericConfigSubscriber(); - sub.subscribe(null, null); + createSubscriber().subscribe(null, null); } @Test(expected=UnsupportedOperationException.class) public void testOverriddenSubscribeInvalid2() { - GenericConfigSubscriber sub = new GenericConfigSubscriber(); - sub.subscribe(null, null, 0L); + createSubscriber().subscribe(null, null, 0L); } @Test(expected=UnsupportedOperationException.class) public void testOverriddenSubscribeInvalid3() { - GenericConfigSubscriber sub = new GenericConfigSubscriber(); - sub.subscribe(null, null, ""); + createSubscriber().subscribe(null, null, ""); } + + private GenericConfigSubscriber createSubscriber() { + return new GenericConfigSubscriber(Map.of( + new ConfigSourceSet("blabla"), + new JRTConfigRequester(new MockConnection(), JRTConfigRequesterTest.getTestTimingValues()))); + } + } |