diff options
| author | Arne Juul <arnej@yahoo-inc.com> | 2018-06-12 12:50:28 +0200 |
|---|---|---|
| committer | Arne Juul <arnej@yahoo-inc.com> | 2018-06-12 13:51:45 +0200 |
| commit | 016e584f0ad5a071e13d75eb8ad5ddb46b8c54f5 (patch) | |
| tree | 869d4e4a4c4b8a9f9ef691b2980009017dece9e6 /config | |
| parent | 22796dddd3dc025018093783328ac87535ffecd9 (diff) | |
use LOG_ABORT not just abort()
* abort() has the unfortunate effect that nothing is seen in the log,
just an event (which is usually not displayed); so ops people don't
see that the program is crashing at all.
* LOG_ABORT("message") will log an error with the message (and the file
and line) before calling abort(), so it's easy to see what happened.
* add or move <vespa/log/log.h> include and LOG_SETUP lines before
LOG_ABORT is used (or included).
Diffstat (limited to 'config')
| -rw-r--r-- | config/src/vespa/config/print/fileconfigformatter.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/config/src/vespa/config/print/fileconfigformatter.cpp b/config/src/vespa/config/print/fileconfigformatter.cpp index 507e1440bae..e4071474760 100644 --- a/config/src/vespa/config/print/fileconfigformatter.cpp +++ b/config/src/vespa/config/print/fileconfigformatter.cpp @@ -7,6 +7,9 @@ #include <cmath> #include <vector> +#include <vespa/log/log.h> +LOG_SETUP(".config.print.fileconfigformatter"); + using namespace vespalib::slime::convenience; using vespalib::slime::ArrayTraverser; @@ -128,7 +131,7 @@ struct ConfigEncoder : public ArrayTraverser, case vespalib::slime::OBJECT::ID: return encodeOBJECT(inspector); case vespalib::slime::NIX::ID: return; } - abort(); // should not be reached + LOG_ABORT("should not be reached"); // should not be reached } void entry(size_t idx, const Inspector &inspector) override; void field(const Memory &symbol_name, const Inspector &inspector) override; |