summaryrefslogtreecommitdiffstats
path: root/config
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2021-09-24 13:07:06 +0200
committerHarald Musum <musum@yahooinc.com>2021-09-24 13:07:06 +0200
commitdfae4a69d17977243d4b04b866162431fdd9d6cb (patch)
tree4cdd39c03944079f93b20483d1cca50b2b3d16d4 /config
parent06f306fcb22c293cc740363a2dac99de0859a09a (diff)
Throw instead of setting config if we get bad config
Diffstat (limited to 'config')
-rw-r--r--config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java11
1 files changed, 3 insertions, 8 deletions
diff --git a/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java b/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java
index e83fc7aefc5..f50ed694115 100644
--- a/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java
+++ b/config/src/main/java/com/yahoo/config/subscription/impl/JRTConfigSubscription.java
@@ -105,16 +105,11 @@ public class JRTConfigSubscription<T extends ConfigInstance> extends ConfigSubsc
}
protected void setNewConfig(JRTClientConfigRequest jrtReq) {
- Exception badConfigE = null;
- T configInstance = null;
try {
- configInstance = toConfigInstance(jrtReq);
+ T configInstance = toConfigInstance(jrtReq);
+ setConfig(jrtReq.getNewGeneration(), jrtReq.responseIsApplyOnRestart(), configInstance, jrtReq.getNewChecksums());
} catch (IllegalArgumentException e) {
- badConfigE = e;
- }
- setConfig(jrtReq.getNewGeneration(), jrtReq.responseIsApplyOnRestart(), configInstance, jrtReq.getNewChecksums());
- if (badConfigE != null) {
- throw new IllegalArgumentException("Bad config from jrt", badConfigE);
+ throw new IllegalArgumentException("Bad config in response", e);
}
}