diff options
author | Harald Musum <musum@verizonmedia.com> | 2020-02-09 22:07:34 +0100 |
---|---|---|
committer | Harald Musum <musum@verizonmedia.com> | 2020-02-09 22:07:34 +0100 |
commit | 741b069e8aa00a4dde1f596103eb78beadac174e (patch) | |
tree | 0d8c1d7cc32e1fde6a2c7f7ff1370c5d8f0672ea /config | |
parent | ac2b4174ed619b80f346d40d8b042761f1f723ed (diff) |
Remove constructor only used in tests
Diffstat (limited to 'config')
-rw-r--r-- | config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java | 4 | ||||
-rw-r--r-- | config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java | 21 |
2 files changed, 11 insertions, 14 deletions
diff --git a/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java b/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java index 328a4d5a0fd..457c15eda3d 100644 --- a/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java +++ b/config/src/main/java/com/yahoo/config/subscription/impl/GenericConfigSubscriber.java @@ -27,10 +27,6 @@ public class GenericConfigSubscriber extends ConfigSubscriber { this.requester = requester; } - public GenericConfigSubscriber() { - super(); - } - /** * Subscribes to config without using a config class. For internal use in config proxy. * diff --git a/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java b/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java index 14dd73c651b..7a10db49408 100644 --- a/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java +++ b/config/src/test/java/com/yahoo/config/subscription/GenericConfigSubscriberTest.java @@ -28,31 +28,32 @@ public class GenericConfigSubscriberTest { @Test public void testSubscribeGeneric() { ConfigSourceSet sourceSet = new ConfigSourceSet("blabla"); - GenericConfigSubscriber sub = new GenericConfigSubscriber(new JRTConfigRequester(new MockConnection(), JRTConfigRequesterTest.getTestTimingValues())); + GenericConfigSubscriber subscriber = createSubscriber(); final List<String> defContent = List.of("myVal int"); - GenericConfigHandle handle = sub.subscribe(new ConfigKey<>("simpletypes", "id", "config"), defContent, sourceSet, JRTConfigRequesterTest.getTestTimingValues()); - assertTrue(sub.nextConfig()); + GenericConfigHandle handle = subscriber.subscribe(new ConfigKey<>("simpletypes", "id", "config"), defContent, sourceSet, JRTConfigRequesterTest.getTestTimingValues()); + assertTrue(subscriber.nextConfig()); assertTrue(handle.isChanged()); assertThat(handle.getRawConfig().getPayload().withCompression(CompressionType.UNCOMPRESSED).toString(), is("{}")); // MockConnection returns empty string - assertFalse(sub.nextConfig()); + assertFalse(subscriber.nextConfig()); assertFalse(handle.isChanged()); } @Test(expected=UnsupportedOperationException.class) public void testOverriddenSubscribeInvalid1() { - GenericConfigSubscriber sub = new GenericConfigSubscriber(); - sub.subscribe(null, null); + createSubscriber().subscribe(null, null); } @Test(expected=UnsupportedOperationException.class) public void testOverriddenSubscribeInvalid2() { - GenericConfigSubscriber sub = new GenericConfigSubscriber(); - sub.subscribe(null, null, 0L); + createSubscriber().subscribe(null, null, 0L); } @Test(expected=UnsupportedOperationException.class) public void testOverriddenSubscribeInvalid3() { - GenericConfigSubscriber sub = new GenericConfigSubscriber(); - sub.subscribe(null, null, ""); + createSubscriber().subscribe(null, null, ""); + } + + private GenericConfigSubscriber createSubscriber() { + return new GenericConfigSubscriber(new JRTConfigRequester(new MockConnection(), JRTConfigRequesterTest.getTestTimingValues())); } } |