summaryrefslogtreecommitdiffstats
path: root/configgen
diff options
context:
space:
mode:
authorHarald Musum <musum@yahoo-inc.com>2017-06-08 14:23:16 +0200
committerGitHub <noreply@github.com>2017-06-08 14:23:16 +0200
commit81149d35c6ed638eddaa4f18d6a5cbc1f4c07146 (patch)
tree56c3af86a163f76f155170cf553ebb64a64389b5 /configgen
parent2990c698b81c8d35d6f9bf47a6d53fca4ecae563 (diff)
Revert "Gjoranv/remove default ctor4"
Diffstat (limited to 'configgen')
-rw-r--r--configgen/src/main/scala/com/yahoo/config/codegen/ConfigGenerator.scala12
1 files changed, 3 insertions, 9 deletions
diff --git a/configgen/src/main/scala/com/yahoo/config/codegen/ConfigGenerator.scala b/configgen/src/main/scala/com/yahoo/config/codegen/ConfigGenerator.scala
index 533b9b2be23..716f2a60c33 100644
--- a/configgen/src/main/scala/com/yahoo/config/codegen/ConfigGenerator.scala
+++ b/configgen/src/main/scala/com/yahoo/config/codegen/ConfigGenerator.scala
@@ -180,14 +180,8 @@ object ConfigGenerator {
}
}
- // TODO: The default ctor is possibly still needed for innerArrays, because of InnerNodeVector.createNew()
- def defaultConstructorIfArray = {
- inner match {
- case array: InnerCNode if inner.isArray => defaultConstructor
- case scalar: InnerCNode => ""
- }
- }
-
+ // TODO: The default ctor can be removed if the config library uses builders to set values from payload, but ...
+ // a default ctor is also needed for all innerArrays, because of InnerNodeVector.createNew()
def defaultConstructor = {
// TODO @link gives javadoc warnings, although the syntax seems to be valid
//def link = "{@link " + {nodeClass(inner)} + "#" + {nodeClass(inner)} + "(Builder)}"
@@ -208,7 +202,7 @@ object ConfigGenerator {
// TODO: merge these two constructors into one when the config library uses builders to set values from payload.
<code>
- |{defaultConstructorIfArray}
+ |{defaultConstructor}
|
|public {nodeClass(inner)}(Builder builder) {{
| this(builder, true);