use new LoggingRequestHandler constructor

15 files changed, 58 insertions, 70 deletions

diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpGetConfigHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpGetConfigHandlerTest.java
index 71f4e4add50..b19d6e2e257 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpGetConfigHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpGetConfigHandlerTest.java
@@ -44,13 +44,9 @@ public class HttpGetConfigHandlerTest {
         mockRequestHandler.setAllConfigs(new HashSet<ConfigKey<?>>() {{ 
             add(new ConfigKey<>("bar", "myid", "foo"));
             }} );
-        handler = new HttpGetConfigHandler(new Executor() {
-            @SuppressWarnings("NullableProblems")
-            @Override
-            public void execute(Runnable command) {
-                command.run();
-            }
-        }, mockRequestHandler, AccessLog.voidAccessLog());
+        handler = new HttpGetConfigHandler(
+                HttpGetConfigHandler.testOnlyContext(),
+                mockRequestHandler);
     }
 
     @Test
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpHandlerTest.java
index 76844bb7c21..bf881e7a546 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpHandlerTest.java
@@ -25,7 +25,7 @@ public class HttpHandlerTest {
     @Test
     public void testResponse() throws IOException {
         final String message = "failed";
-        HttpHandler httpHandler = new HttpTestHandler(Executors.newSingleThreadExecutor(), AccessLog.voidAccessLog(), new InvalidApplicationException(message));
+        HttpHandler httpHandler = new HttpTestHandler(new InvalidApplicationException(message));
         HttpResponse response = httpHandler.handle(HttpRequest.createTestRequest("foo", com.yahoo.jdisc.http.HttpRequest.Method.GET));
         assertThat(response.getStatus(), is(Response.Status.BAD_REQUEST));
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
@@ -38,8 +38,8 @@ public class HttpHandlerTest {
 
     private static class HttpTestHandler extends HttpHandler {
         private RuntimeException exception;
-        public HttpTestHandler(Executor executor, AccessLog accessLog, RuntimeException exception) {
-            super(executor, accessLog);
+        public HttpTestHandler(RuntimeException exception) {
+            super(HttpHandler.testOnlyContext());
             this.exception = exception;
         }
 
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpListConfigsHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpListConfigsHandlerTest.java
index db8526150bf..01618e5a85f 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpListConfigsHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/HttpListConfigsHandlerTest.java
@@ -37,18 +37,9 @@ public class HttpListConfigsHandlerTest {
         mockRequestHandler.setAllConfigs(new HashSet<ConfigKey<?>>() {{ 
             add(new ConfigKey<>("bar", "conf/id/", "foo"));
             }} );
-        handler = new HttpListConfigsHandler(new Executor() {
-            @Override
-            public void execute(Runnable command) {
-                command.run();
-            }
-        }, AccessLog.voidAccessLog(), mockRequestHandler);
-        namedHandler = new HttpListNamedConfigsHandler(new Executor() {
-            @Override
-            public void execute(Runnable command) {
-                command.run();
-            }
-        }, mockRequestHandler, AccessLog.voidAccessLog());
+        HttpListConfigsHandler.Context ctx = HttpListConfigsHandler.testOnlyContext();
+        handler = new HttpListConfigsHandler(ctx, mockRequestHandler);
+        namedHandler = new HttpListNamedConfigsHandler(ctx, mockRequestHandler);
     }
     
     @Test
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/SessionExampleHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/SessionExampleHandlerTest.java
index 7aff8f9410b..b6d9ab5d618 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/SessionExampleHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/SessionExampleHandlerTest.java
@@ -54,7 +54,7 @@ public class SessionExampleHandlerTest {
     public static class SessionExampleHandler extends ThreadedHttpRequestHandler {
 
         public SessionExampleHandler(Executor executor) {
-            super(executor);
+            super(executor, null);
         }
 
         @Override
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationContentHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationContentHandlerTest.java
index a17d485a425..c34dbe76a43 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationContentHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationContentHandlerTest.java
@@ -52,8 +52,7 @@ public class ApplicationContentHandlerTest extends ContentHandlerTestBase {
         testTenantBuilder.tenants().get(tenant2).getLocalSessionRepo().addSession(new MockSession(3l, FilesApplicationPackage.fromFile(new File("src/test/apps/content2"))));
         testTenantBuilder.tenants().get(tenant1).getApplicationRepo().createPutApplicationTransaction(idTenant1, 2l).commit();
         testTenantBuilder.tenants().get(tenant2).getApplicationRepo().createPutApplicationTransaction(idTenant2, 3l).commit();
-        handler = new ApplicationHandler(Runnable::run,
-                                         AccessLog.voidAccessLog(),
+        handler = new ApplicationHandler(ApplicationHandler.testOnlyContext(),
                                          Zone.defaultZone(),
                                          new ApplicationRepository(testTenantBuilder.createTenants(),
                                                                    new MockProvisioner(),
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationHandlerTest.java
index 5552758a0a6..8ac64e5b28a 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ApplicationHandlerTest.java
@@ -96,7 +96,8 @@ public class ApplicationHandlerTest {
                 mockHttpProxy,
                 new MockLogServerLogGrabber());
         listApplicationsHandler = new ListApplicationsHandler(
-                Runnable::run, AccessLog.voidAccessLog(), tenants, Zone.defaultZone());
+                ListApplicationsHandler.testOnlyContext(),
+                tenants, Zone.defaultZone());
     }
 
     private ApplicationHandler createMockApplicationHandler(
@@ -105,8 +106,7 @@ public class ApplicationHandlerTest {
             HttpProxy httpProxy,
             LogServerLogGrabber logServerLogGrabber) {
         return new ApplicationHandler(
-                Runnable::run,
-                AccessLog.voidAccessLog(),
+                ApplicationHandler.testOnlyContext(),
                 Zone.defaultZone(),
                 new ApplicationRepository(tenants,
                                           HostProvisionerProvider.withProvisioner(provisioner),
@@ -118,8 +118,7 @@ public class ApplicationHandlerTest {
 
     private ApplicationHandler createApplicationHandler(Tenants tenants) {
         return new ApplicationHandler(
-                Runnable::run,
-                AccessLog.voidAccessLog(),
+                ApplicationHandler.testOnlyContext(),
                 Zone.defaultZone(),
                 new ApplicationRepository(tenants,
                                           HostProvisionerProvider.withProvisioner(provisioner),
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HostHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HostHandlerTest.java
index e439f424c45..fe25170d8ba 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HostHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HostHandlerTest.java
@@ -52,9 +52,9 @@ public class HostHandlerTest {
         hostRegistries = testComponentRegistry.getHostRegistries();
         hostRegistries.createApplicationHostRegistry(mytenant).update(ApplicationId.from(mytenant, ApplicationName.defaultName(), InstanceName.defaultName()), Collections.singletonList(hostname));
         hostRegistries.getTenantHostRegistry().update(mytenant, Collections.singletonList(hostname));
-        hostHandler = new HostHandler(command -> {
-            command.run();
-        }, AccessLog.voidAccessLog(), testComponentRegistry);
+        hostHandler = new HostHandler(
+                HostHandler.testOnlyContext(),
+                testComponentRegistry);
         return hostHandler;
     }
 
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpGetConfigHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpGetConfigHandlerTest.java
index cc18e279002..11bacc30b27 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpGetConfigHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpGetConfigHandlerTest.java
@@ -49,9 +49,9 @@ public class HttpGetConfigHandlerTest {
         TestTenantBuilder tb = new TestTenantBuilder();
         tb.createTenant(tenant).withRequestHandler(mockRequestHandler).build();
         Tenants tenants = tb.createTenants();        
-        handler = new HttpGetConfigHandler(command -> {
-            command.run();
-        }, AccessLog.voidAccessLog(), tenants);
+        handler = new HttpGetConfigHandler(
+                HttpGetConfigHandler.testOnlyContext(),
+                tenants);
     }
 
     @Test
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpListConfigsHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpListConfigsHandlerTest.java
index a66e9542a5f..e7ccd9f957e 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpListConfigsHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/HttpListConfigsHandlerTest.java
@@ -45,12 +45,12 @@ public class HttpListConfigsHandlerTest {
         TestTenantBuilder tb = new TestTenantBuilder();
         tb.createTenant(TenantName.from("mytenant")).withRequestHandler(mockRequestHandler).build();
         Tenants tenants = tb.createTenants();
-        handler = new HttpListConfigsHandler(command -> {
-            command.run();
-        }, AccessLog.voidAccessLog(), tenants, Zone.defaultZone());
-        namedHandler = new HttpListNamedConfigsHandler(command -> {
-            command.run();
-        }, AccessLog.voidAccessLog(), tenants, Zone.defaultZone());
+        handler = new HttpListConfigsHandler(
+                HttpListConfigsHandler.testOnlyContext(),
+                tenants, Zone.defaultZone());
+        namedHandler = new HttpListNamedConfigsHandler(
+                HttpListConfigsHandler.testOnlyContext(),
+                tenants, Zone.defaultZone());
     }
     
     @Test
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ListApplicationsHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ListApplicationsHandlerTest.java
index 9e7853a8fdf..3233d9598d1 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ListApplicationsHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/ListApplicationsHandlerTest.java
@@ -39,10 +39,10 @@ public class ListApplicationsHandlerTest {
         applicationRepo = testBuilder.tenants().get(mytenant).getApplicationRepo();
         applicationRepo2 = testBuilder.tenants().get(foobar).getApplicationRepo();
         Tenants tenants = testBuilder.createTenants();
-        handler = new ListApplicationsHandler(Runnable::run,
-                                              AccessLog.voidAccessLog(),
-                                              tenants,
-                                              new Zone(Environment.dev, RegionName.from("us-east")));
+        handler = new ListApplicationsHandler(
+                ListApplicationsHandler.testOnlyContext(),
+                tenants,
+                new Zone(Environment.dev, RegionName.from("us-east")));
     }
 
     @Test
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionActiveHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionActiveHandlerTest.java
index 6542c865d56..04bc8d7b49a 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionActiveHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionActiveHandlerTest.java
@@ -373,13 +373,12 @@ public class SessionActiveHandlerTest extends SessionHandlerTest {
                 .withApplicationRepo(applicationRepo)
                 .build();
         return new SessionActiveHandler(
-                Runnable::run,
-                AccessLog.voidAccessLog(),
-                testTenantBuilder.createTenants(),
-                Zone.defaultZone(),
+                SessionActiveHandler.testOnlyContext(),
                 new ApplicationRepository(testTenantBuilder.createTenants(),
                                           hostProvisioner,
-                                          Clock.systemUTC()));
+                                          Clock.systemUTC()),
+                testTenantBuilder.createTenants(),
+                Zone.defaultZone());
     }
 
 }
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionContentHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionContentHandlerTest.java
index 1d831032416..e4841930cc8 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionContentHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionContentHandlerTest.java
@@ -161,15 +161,11 @@ public class SessionContentHandlerTest extends ContentHandlerTestBase {
     private SessionContentHandler createHandler() throws Exception {
         TestTenantBuilder testTenantBuilder = new TestTenantBuilder();
         testTenantBuilder.createTenant(tenant).getLocalSessionRepo().addSession(new MockSession(1l, FilesApplicationPackage.fromFile(createTestApp())));
-        return new SessionContentHandler(new Executor() {
-            @SuppressWarnings("NullableProblems")
-            @Override
-            public void execute(Runnable command) {
-                command.run();
-            }
-        }, AccessLog.voidAccessLog(), testTenantBuilder.createTenants(),
-                                         new ApplicationRepository(testTenantBuilder.createTenants(),
-                                                                   new SessionHandlerTest.MockProvisioner(),
-                                                                   Clock.systemUTC()));
+        return new SessionContentHandler(
+                SessionContentHandler.testOnlyContext(),
+                new ApplicationRepository(testTenantBuilder.createTenants(),
+                                          new SessionHandlerTest.MockProvisioner(),
+                                          Clock.systemUTC()),
+                testTenantBuilder.createTenants());
     }
 }
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionCreateHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionCreateHandlerTest.java
index 65b12490b17..fc9264a6ef5 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionCreateHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionCreateHandlerTest.java
@@ -243,10 +243,13 @@ public class SessionCreateHandlerTest extends SessionHandlerTest {
     private SessionCreateHandler createHandler(Tenants tenants) throws Exception {
         TestTenantBuilder testTenantBuilder = new TestTenantBuilder();
         final ConfigserverConfig configserverConfig = new ConfigserverConfig(new ConfigserverConfig.Builder());
-        return new SessionCreateHandler(Runnable::run, AccessLog.voidAccessLog(), tenants, configserverConfig,
-                                        new ApplicationRepository(testTenantBuilder.createTenants(),
-                                                                  new SessionHandlerTest.MockProvisioner(),
-                                                                  Clock.systemUTC()));
+        return new SessionCreateHandler(
+                SessionCreateHandler.testOnlyContext(),
+                new ApplicationRepository(testTenantBuilder.createTenants(),
+                                          new SessionHandlerTest.MockProvisioner(),
+                                          Clock.systemUTC()),
+                tenants, configserverConfig);
+
     }
 
     private HttpRequest post() throws FileNotFoundException {
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionPrepareHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionPrepareHandlerTest.java
index 74a2dcf8054..1759cd68062 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionPrepareHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/SessionPrepareHandlerTest.java
@@ -383,10 +383,13 @@ public class SessionPrepareHandlerTest extends SessionHandlerTest {
 
     private SessionHandler createHandler(TestTenantBuilder builder) {
         final ConfigserverConfig configserverConfig = new ConfigserverConfig(new ConfigserverConfig.Builder());
-        return new SessionPrepareHandler(Runnable::run, AccessLog.voidAccessLog(), builder.createTenants(), configserverConfig,
-                                         new ApplicationRepository(builder.createTenants(),
-                                                                   new MockProvisioner(),
-                                                                   Clock.systemUTC()));
+        return new SessionPrepareHandler(
+                SessionPrepareHandler.testOnlyContext(),
+                new ApplicationRepository(builder.createTenants(),
+                                          new MockProvisioner(),
+                                          Clock.systemUTC()),
+                builder.createTenants(), configserverConfig);
+
     }
 
     private TestTenantBuilder addTenant(TenantName tenantName,
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java
index ce4b25fe529..e948bf68970 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java
@@ -27,7 +27,9 @@ public class TenantHandlerTest extends TenantTest {
 
     @Before
     public void setup() throws Exception {
-        handler = new TenantHandler(testExecutor(), null, tenants);
+        handler = new TenantHandler(
+                TenantHandler.testOnlyContext(),
+                tenants);
     }
 
     @Test