aboutsummaryrefslogtreecommitdiffstats
path: root/configserver
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2021-04-30 13:16:39 +0200
committerJon Marius Venstad <venstad@gmail.com>2021-04-30 13:16:39 +0200
commit44f7c2dc80a1dff60226119c549695e9a2cae369 (patch)
tree2ca1334df45d7eea6dfb35d99fc875762c92b732 /configserver
parent3f18254fe2428c5a3dfd5c014daf09e025003c80 (diff)
Revert "Merge pull request #17664 from vespa-engine/revert-17658-jonmv/rest-api-bindings-without-trailing-slash"
This reverts commit 9de25e274dbec90a81d9fc107a429dc275c76deb, reversing changes made to 2a8254e4a8e61916974016a6d9933cd406443096.
Diffstat (limited to 'configserver')
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/http/v2/TenantHandler.java3
-rw-r--r--configserver/src/main/resources/configserver-app/services.xml3
-rw-r--r--configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java3
3 files changed, 6 insertions, 3 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/http/v2/TenantHandler.java b/configserver/src/main/java/com/yahoo/vespa/config/server/http/v2/TenantHandler.java
index 6aff3b8a361..9063c5137ef 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/http/v2/TenantHandler.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/http/v2/TenantHandler.java
@@ -93,6 +93,7 @@ public class TenantHandler extends HttpHandler {
private static BindingMatch<?> getBindingMatch(HttpRequest request) {
return HttpConfigRequests.getBindingMatch(request,
+ "http://*/application/v2/tenant",
"http://*/application/v2/tenant/",
"http://*/application/v2/tenant/*");
}
@@ -103,7 +104,7 @@ public class TenantHandler extends HttpHandler {
private static boolean isListTenantsRequest(HttpRequest request) {
return getBindingMatch(request).groupCount() == 2 &&
- request.getUri().getPath().endsWith("/tenant/");
+ request.getUri().getPath().matches("/application/v2/tenant/?");
}
private static TenantName getTenantNameFromRequest(HttpRequest request) {
diff --git a/configserver/src/main/resources/configserver-app/services.xml b/configserver/src/main/resources/configserver-app/services.xml
index fd8bda8f305..73aa5db98e4 100644
--- a/configserver/src/main/resources/configserver-app/services.xml
+++ b/configserver/src/main/resources/configserver-app/services.xml
@@ -102,8 +102,7 @@
<binding>http://*/status</binding>
</handler>
<handler id='com.yahoo.vespa.config.server.http.v2.TenantHandler' bundle='configserver'>
- <binding>http://*/application/v2/tenant/</binding>
- <binding>http://*/application/v2/tenant/*</binding>
+ <binding>http://*/application/v2/tenant*</binding>
</handler>
<handler id='com.yahoo.vespa.config.server.http.v2.SessionCreateHandler' bundle='configserver'>
<binding>http://*/application/v2/tenant/*/session</binding>
diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java
index b0b01ea24b4..e7723f75ffc 100644
--- a/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java
+++ b/configserver/src/test/java/com/yahoo/vespa/config/server/http/v2/TenantHandlerTest.java
@@ -102,6 +102,9 @@ public class TenantHandlerTest {
assertResponseEquals((ListTenantsResponse) handler.handleGET(
HttpRequest.createTestRequest("http://deploy.example.yahoo.com:80/application/v2/tenant/", Method.GET)),
"{\"tenants\":[\"default\",\"a\"]}");
+ assertResponseEquals((ListTenantsResponse) handler.handleGET(
+ HttpRequest.createTestRequest("http://deploy.example.yahoo.com:80/application/v2/tenant", Method.GET)),
+ "{\"tenants\":[\"default\",\"a\"]}");
}
@Test(expected=BadRequestException.class)