summaryrefslogtreecommitdiffstats
path: root/configserver
diff options
context:
space:
mode:
authorHarald Musum <musum@oath.com>2018-05-31 17:27:18 +0200
committerHarald Musum <musum@oath.com>2018-05-31 17:27:18 +0200
commit7a3b2eff5cb659bd9927ec58511b4d8ad59d6850 (patch)
treee076e16fe985d2c1f6ac2a3a69af6c8e292e4ba5 /configserver
parentbf606d66b40535c569a50e17c43cbe7913d63d26 (diff)
Run TenantsMaintainer in test systems and delete unused files in CD
Diffstat (limited to 'configserver')
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ConfigServerMaintenance.java10
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java2
2 files changed, 8 insertions, 4 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ConfigServerMaintenance.java b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ConfigServerMaintenance.java
index a08b077699c..c6a390caf86 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ConfigServerMaintenance.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ConfigServerMaintenance.java
@@ -3,7 +3,7 @@ package com.yahoo.vespa.config.server.maintenance;
import com.yahoo.cloud.config.ConfigserverConfig;
import com.yahoo.component.AbstractComponent;
-import com.yahoo.config.model.api.FileDistribution;
+import com.yahoo.config.provision.Environment;
import com.yahoo.config.provision.SystemName;
import com.yahoo.vespa.config.server.ApplicationRepository;
import com.yahoo.vespa.config.server.session.FileDistributionFactory;
@@ -46,10 +46,14 @@ public class ConfigServerMaintenance extends AbstractComponent {
DefaultTimes(ConfigserverConfig configserverConfig) {
boolean isCd = configserverConfig.system().equals(SystemName.cd.name());
+ boolean isTest = Environment.from(configserverConfig.environment()).isTest();
this.defaultInterval = Duration.ofMinutes(configserverConfig.maintainerIntervalMinutes());
- // TODO: Want job control or feature flag to control when to run this, for now use a very long interval unless in CD
- this.tenantsMaintainerInterval = isCd ? defaultInterval : Duration.ofMinutes(configserverConfig.tenantsMaintainerIntervalMinutes());
+ // TODO: Want job control or feature flag to control when to run this, for now use a very
+ // long interval to avoid running the maintainer
+ this.tenantsMaintainerInterval = isCd || isTest
+ ? defaultInterval
+ : Duration.ofMinutes(configserverConfig.tenantsMaintainerIntervalMinutes());
}
}
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java
index 8f4a90ef85f..779571b737e 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java
@@ -265,7 +265,7 @@ public class TenantRepository implements ConnectionStateListener, PathChildrenCa
public synchronized TenantRepository deleteTenant(TenantName name) {
if (name.equals(DEFAULT_TENANT))
throw new IllegalArgumentException("Deleting 'default' tenant is not allowed");
- log.log(LogLevel.DEBUG, "Deleting tenant '" + name + "'");
+ log.log(LogLevel.INFO, "Deleting tenant '" + name + "'");
Tenant tenant = tenants.remove(name);
if (tenant == null) {
throw new IllegalArgumentException("Deleting '" + name + "' failed, tenant does not exist");