summaryrefslogtreecommitdiffstats
path: root/configserver
diff options
context:
space:
mode:
authorØyvind Grønnesby <oyving@verizonmedia.com>2019-07-29 16:05:49 +0200
committerØyvind Grønnesby <oyving@verizonmedia.com>2019-07-29 16:05:49 +0200
commit2442a786e602a96548e57f8f67b07446f72f7bb5 (patch)
tree9748e0e3ece6fc55027fc4ec75858b9cc09cd8b8 /configserver
parente1218592e3b4973e1029a7ee798ef7ea26b2abc7 (diff)
Fix error message and use .valid() for testing for parse error
Diffstat (limited to 'configserver')
-rw-r--r--configserver/src/main/java/com/yahoo/vespa/config/server/metrics/MetricsRetriever.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/metrics/MetricsRetriever.java b/configserver/src/main/java/com/yahoo/vespa/config/server/metrics/MetricsRetriever.java
index 191014ded78..01255fb5c2e 100644
--- a/configserver/src/main/java/com/yahoo/vespa/config/server/metrics/MetricsRetriever.java
+++ b/configserver/src/main/java/com/yahoo/vespa/config/server/metrics/MetricsRetriever.java
@@ -41,10 +41,10 @@ public class MetricsRetriever {
private void getHostMetrics(URI hostURI, MetricsAggregator metrics) {
Slime responseBody = doMetricsRequest(hostURI);
- var parseError = responseBody.get().field("error_message").asString();
+ var parseError = responseBody.get().field("error_message");
- if (! parseError.isEmpty()) {
- log.info("Failed to retrieve logs from " + hostURI + ": " + parseError);
+ if (parseError.valid()) {
+ log.info("Failed to retrieve metrics from " + hostURI + ": " + parseError.asString());
}
Inspector services = responseBody.get().field("services");