diff options
author | Harald Musum <musum@verizonmedia.com> | 2021-02-18 09:28:57 +0100 |
---|---|---|
committer | Harald Musum <musum@verizonmedia.com> | 2021-02-18 09:28:57 +0100 |
commit | 39c04cd787e0bb8eef4b69227a61599ca45440cd (patch) | |
tree | 408c41c5cef0e6b37cad4a77f89078d6a40a7fbb /configserver | |
parent | ea223f582f274d7d57bf65ea295f1269e236c439 (diff) |
Simplify
Diffstat (limited to 'configserver')
4 files changed, 14 insertions, 21 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/session/SessionRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/session/SessionRepository.java index 491c3bc8298..76fd57a51cf 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/session/SessionRepository.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/session/SessionRepository.java @@ -124,7 +124,6 @@ public class SessionRepository { public SessionRepository(TenantName tenantName, TenantApplications applicationRepo, SessionPreparer sessionPreparer, - Curator curator, ConfigCurator configCurator, Metrics metrics, StripedExecutor<TenantName> zkWatcherExecutor, @@ -145,7 +144,7 @@ public class SessionRepository { sessionCounter = new SessionCounter(configCurator, tenantName); this.sessionsPath = TenantRepository.getSessionsPath(tenantName); this.clock = clock; - this.curator = curator; + this.curator = configCurator.curator(); this.sessionLifetime = Duration.ofSeconds(configserverConfig.sessionLifetime()); this.zkWatcherExecutor = command -> zkWatcherExecutor.execute(tenantName, command); this.permanentApplicationPackage = permanentApplicationPackage; diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java index 54b79aa79dd..babb7e4a596 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/tenant/TenantRepository.java @@ -125,7 +125,7 @@ public class TenantRepository { */ @Inject public TenantRepository(HostRegistry hostRegistry, - Curator curator, + ConfigCurator configCurator, Metrics metrics, FlagSource flagSource, SecretStore secretStore, @@ -136,10 +136,9 @@ public class TenantRepository { ModelFactoryRegistry modelFactoryRegistry, ConfigDefinitionRepo configDefinitionRepo, ReloadListener reloadListener, - TenantListener tenantListener, - ConfigCurator configCurator) { + TenantListener tenantListener) { this(hostRegistry, - curator, + configCurator, metrics, new StripedExecutor<>(), new FileDistributionFactory(configserverConfig), @@ -154,12 +153,11 @@ public class TenantRepository { modelFactoryRegistry, configDefinitionRepo, reloadListener, - tenantListener, - configCurator); + tenantListener); } public TenantRepository(HostRegistry hostRegistry, - Curator curator, + ConfigCurator configCurator, Metrics metrics, StripedExecutor<TenantName> zkWatcherExecutor, FileDistributionFactory fileDistributionFactory, @@ -174,13 +172,12 @@ public class TenantRepository { ModelFactoryRegistry modelFactoryRegistry, ConfigDefinitionRepo configDefinitionRepo, ReloadListener reloadListener, - TenantListener tenantListener, - ConfigCurator configCurator) { + TenantListener tenantListener) { this.hostRegistry = hostRegistry; this.configserverConfig = configserverConfig; this.bootstrapExecutor = Executors.newFixedThreadPool(configserverConfig.numParallelTenantLoaders(), new DaemonThreadFactory("bootstrap-tenant-")); - this.curator = curator; + this.curator = configCurator.curator(); this.metrics = metrics; metricUpdater = metrics.getOrCreateMetricUpdater(Collections.emptyMap()); this.zkCacheExecutor = zkCacheExecutor; @@ -338,7 +335,6 @@ public class TenantRepository { SessionRepository sessionRepository = new SessionRepository(tenantName, applicationRepo, sessionPreparer, - curator, configCurator, metrics, zkWatcherExecutor, diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TenantRepositoryTest.java b/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TenantRepositoryTest.java index 313d94f63ab..b3d1495eb6b 100644 --- a/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TenantRepositoryTest.java +++ b/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TenantRepositoryTest.java @@ -194,7 +194,7 @@ public class TenantRepositoryTest { // Should get exception if config is true expectedException.expect(RuntimeException.class); expectedException.expectMessage("Could not create all tenants when bootstrapping, failed to create: [default]"); - new FailingDuringBootstrapTenantRepository(configserverConfig, new MockCurator()); + new FailingDuringBootstrapTenantRepository(configserverConfig); } private List<String> readZKChildren(String path) throws Exception { @@ -207,9 +207,9 @@ public class TenantRepositoryTest { private static class FailingDuringBootstrapTenantRepository extends TenantRepository { - public FailingDuringBootstrapTenantRepository(ConfigserverConfig configserverConfig, Curator curator) { + public FailingDuringBootstrapTenantRepository(ConfigserverConfig configserverConfig) { super(new HostRegistry(), - curator, + ConfigCurator.create(new MockCurator()), Metrics.createTestMetrics(), new StripedExecutor<>(new InThreadExecutorService()), new FileDistributionFactory(new ConfigserverConfig.Builder().build()), @@ -224,8 +224,7 @@ public class TenantRepositoryTest { new ModelFactoryRegistry(List.of(new VespaModelFactory(new NullConfigModelRegistry()))), new TestConfigDefinitionRepo(), new TenantApplicationsTest.MockReloadListener(), - new MockTenantListener(), - ConfigCurator.create(curator)); + new MockTenantListener()); } @Override diff --git a/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TestTenantRepository.java b/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TestTenantRepository.java index 7bd2db19615..8279bf4df5e 100644 --- a/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TestTenantRepository.java +++ b/configserver/src/test/java/com/yahoo/vespa/config/server/tenant/TestTenantRepository.java @@ -47,7 +47,7 @@ public class TestTenantRepository extends TenantRepository { ReloadListener reloadListener, TenantListener tenantListener) { super(hostRegistry, - curator, + ConfigCurator.create(curator), metrics, new StripedExecutor<>(new InThreadExecutorService()), fileDistributionFactory, @@ -62,8 +62,7 @@ public class TestTenantRepository extends TenantRepository { modelFactoryRegistry, configDefinitionRepo, reloadListener, - tenantListener, - ConfigCurator.create(curator)); + tenantListener); } public static class Builder { |