diff options
author | Harald Musum <musum@yahooinc.com> | 2021-11-28 18:32:49 +0100 |
---|---|---|
committer | Harald Musum <musum@yahooinc.com> | 2021-11-28 18:32:49 +0100 |
commit | b00e539c2995b4ed150621237b86d2bc5c33aecf (patch) | |
tree | 985ff4718d7682f9a2241d3ab9319dbc69950741 /configserver | |
parent | 434fd1cdb6dee96513779a4a2a6719e9bb4c8b62 (diff) |
M0;95;0cove logging in getFile() to callers
Diffstat (limited to 'configserver')
2 files changed, 6 insertions, 3 deletions
diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/FileServer.java b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/FileServer.java index 02fad2357c3..79337f3d32b 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/FileServer.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/filedistribution/FileServer.java @@ -194,7 +194,10 @@ public class FileServer { // Create new FileReferenceDownload with downloadFromOtherSourceIfNotFound set to false // to avoid config servers requesting a file reference perpetually, e.g. for a file that does not exist anymore FileReferenceDownload newDownload = new FileReferenceDownload(fileReference, false, fileReferenceDownload.client()); - return downloader.getFile(newDownload).isPresent(); + boolean fileExists = downloader.getFile(newDownload).isPresent(); + if ( ! fileExists) + log.log(Level.WARNING, "Failed downloading '" + fileReferenceDownload + "'"); + return fileExists; } else { log.log(Level.FINE, "File not found, will not download from another source, since request came from another config server"); return false; diff --git a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java index 9cc475a56a0..d8295373207 100644 --- a/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java +++ b/configserver/src/main/java/com/yahoo/vespa/config/server/maintenance/ApplicationPackageMaintainer.java @@ -82,8 +82,8 @@ public class ApplicationPackageMaintainer extends ConfigServerMaintainer { this.getClass().getSimpleName()); if (fileDownloader.getFile(download).isEmpty()) { failures++; - log.warning("Failed to download application package (" + appFileReference + ")" + - " for " + applicationId + " (session " + sessionId + ")"); + log.info("Failed downloading application package (" + appFileReference + ")" + + " for " + applicationId + " (session " + sessionId + ")"); continue; } } |