diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2018-09-26 14:25:33 +0200 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2018-09-26 14:25:33 +0200 |
commit | b3dcb9755c380095a7e077db502deb6279f2cd37 (patch) | |
tree | dcc0891bd12a98ba7be576d740ae2e0d02e53d26 /container-accesslogging | |
parent | b9a92932a8d8c04e1b919112ad95ecd7a49c56d9 (diff) |
Fix comments from pull request review.
- Better naming and make static what can be static.
Diffstat (limited to 'container-accesslogging')
-rw-r--r-- | container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java b/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java index 95f056288d5..9963429bf97 100644 --- a/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java +++ b/container-accesslogging/src/main/java/com/yahoo/container/logging/LogFileHandler.java @@ -276,16 +276,16 @@ public class LogFileHandler extends StreamHandler { private void triggerCompression(String oldFileName) { try { - String zippedFileName = oldFileName + ".gz"; + String gzippedFileName = oldFileName + ".gz"; Runtime r = Runtime.getRuntime(); StringBuilder cmd = new StringBuilder("gzip"); - cmd.append(" < "). append(oldFileName).append(" > ").append(zippedFileName); + cmd.append(" < "). append(oldFileName).append(" > ").append(gzippedFileName); Process p = r.exec(cmd.toString()); NativeIO nativeIO = new NativeIO(); File oldFile = new File(oldFileName); - nativeIO.dropFileFromCache(oldFile); + nativeIO.dropFileFromCache(oldFile); // Drop from cache in case somebody else has a reference to it preventing from dying quickly. oldFile.delete(); - nativeIO.dropFileFromCache(new File(zippedFileName)); + nativeIO.dropFileFromCache(new File(gzippedFileName)); // Detonator pattern: Think of all the fun we can have if gzip isn't what we // think it is, if it doesn't return, etc, etc } catch (IOException e) { |