diff options
author | Håkon Hallingstad <hakon@verizonmedia.com> | 2020-10-10 21:31:28 +0200 |
---|---|---|
committer | Håkon Hallingstad <hakon@verizonmedia.com> | 2020-10-10 21:31:28 +0200 |
commit | b722d66b6347bc42254d9014f320413b187f7ae6 (patch) | |
tree | a1d7d6e0d01c8fac92dbc51e2d49bd81aa18f4e3 /container-core/src/test/java/com/yahoo/container/jdisc/state | |
parent | 805abcff704b2d2f8ae24dcebdad500cc7a658d3 (diff) |
Avoid mock thread factory and simplify construction
Diffstat (limited to 'container-core/src/test/java/com/yahoo/container/jdisc/state')
2 files changed, 2 insertions, 8 deletions
diff --git a/container-core/src/test/java/com/yahoo/container/jdisc/state/StateHandlerTestBase.java b/container-core/src/test/java/com/yahoo/container/jdisc/state/StateHandlerTestBase.java index 6b44115016f..57a9ba4abdb 100644 --- a/container-core/src/test/java/com/yahoo/container/jdisc/state/StateHandlerTestBase.java +++ b/container-core/src/test/java/com/yahoo/container/jdisc/state/StateHandlerTestBase.java @@ -22,14 +22,12 @@ import org.junit.Before; import java.io.InputStreamReader; import java.io.Reader; import java.nio.charset.StandardCharsets; -import java.util.concurrent.ThreadFactory; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicLong; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertTrue; -import static org.mockito.Mockito.mock; /** * @author Simon Thoresen Hult @@ -59,8 +57,7 @@ public class StateHandlerTestBase { new HealthMonitorConfig.Builder() .snapshot_interval(TimeUnit.MILLISECONDS.toSeconds(SNAPSHOT_INTERVAL)) .initialStatus("up")); - ThreadFactory threadFactory = ignored -> mock(Thread.class); - this.monitor = new StateMonitor(healthMonitorConfig, timer, threadFactory); + this.monitor = new StateMonitor(healthMonitorConfig, timer, null); builder.guiceModules().install(new AbstractModule() { @Override diff --git a/container-core/src/test/java/com/yahoo/container/jdisc/state/StateMonitorBenchmarkTest.java b/container-core/src/test/java/com/yahoo/container/jdisc/state/StateMonitorBenchmarkTest.java index 3892f81b8b5..22a2fc274c7 100644 --- a/container-core/src/test/java/com/yahoo/container/jdisc/state/StateMonitorBenchmarkTest.java +++ b/container-core/src/test/java/com/yahoo/container/jdisc/state/StateMonitorBenchmarkTest.java @@ -2,12 +2,10 @@ package com.yahoo.container.jdisc.state; import com.google.inject.Provider; -import com.yahoo.container.jdisc.config.HealthMonitorConfig; import com.yahoo.jdisc.Metric; import com.yahoo.jdisc.application.ContainerThread; import com.yahoo.jdisc.application.MetricConsumer; import com.yahoo.jdisc.application.MetricProvider; -import com.yahoo.jdisc.core.SystemTimer; import org.junit.Test; import java.util.ArrayList; @@ -32,8 +30,7 @@ public class StateMonitorBenchmarkTest { @Test public void requireThatHealthMonitorDoesNotBlockMetricThreads() throws Exception { - StateMonitor monitor = new StateMonitor(new HealthMonitorConfig(new HealthMonitorConfig.Builder()), - new SystemTimer()); + StateMonitor monitor = StateMonitor.createForTesting(); Provider<MetricConsumer> provider = MetricConsumerProviders.wrap(monitor); performUpdates(provider, 8); for (int i = 1; i <= NUM_THREADS; i *= 2) { |