summaryrefslogtreecommitdiffstats
path: root/container-core/src/test/java/com/yahoo/container
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2024-04-11 10:27:59 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2024-04-11 16:07:22 +0200
commit48b9513ee685145d338e0cf9970193ba8254ce33 (patch)
treed9f489b0c1ffd448bc067441b032adfb1c379f1b /container-core/src/test/java/com/yahoo/container
parentef1cf91e0d21ceb4c40d1a6efd62d3dabd08cb86 (diff)
Unify on Set.of
Diffstat (limited to 'container-core/src/test/java/com/yahoo/container')
-rw-r--r--container-core/src/test/java/com/yahoo/container/di/ConfigRetrieverTest.java15
-rw-r--r--container-core/src/test/java/com/yahoo/container/handler/threadpool/ContainerThreadPoolImplTest.java4
2 files changed, 9 insertions, 10 deletions
diff --git a/container-core/src/test/java/com/yahoo/container/di/ConfigRetrieverTest.java b/container-core/src/test/java/com/yahoo/container/di/ConfigRetrieverTest.java
index 14349d4cd51..7240b6510c5 100644
--- a/container-core/src/test/java/com/yahoo/container/di/ConfigRetrieverTest.java
+++ b/container-core/src/test/java/com/yahoo/container/di/ConfigRetrieverTest.java
@@ -15,7 +15,6 @@ import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import java.io.File;
-import java.util.Collections;
import java.util.HashSet;
import java.util.Set;
@@ -45,7 +44,7 @@ public class ConfigRetrieverTest {
void require_that_bootstrap_configs_come_first() {
writeConfigs();
ConfigRetriever retriever = createConfigRetriever();
- ConfigSnapshot bootstrapConfigs = retriever.getConfigs(Collections.emptySet(), 0, true);
+ ConfigSnapshot bootstrapConfigs = retriever.getConfigs(Set.of(), 0, true);
assertTrue(bootstrapConfigs instanceof BootstrapConfigs);
retriever.shutdown();
@@ -56,10 +55,10 @@ public class ConfigRetrieverTest {
void require_that_components_comes_after_bootstrap() {
writeConfigs();
ConfigRetriever retriever = createConfigRetriever();
- ConfigSnapshot bootstrapConfigs = retriever.getConfigs(Collections.emptySet(), 0, true);
+ ConfigSnapshot bootstrapConfigs = retriever.getConfigs(Set.of(), 0, true);
ConfigKey<? extends ConfigInstance> testConfigKey = new ConfigKey<>(TestConfig.class, dirConfigSource.configId());
- ConfigSnapshot componentsConfigs = retriever.getConfigs(Collections.singleton(testConfigKey), 0, true);
+ ConfigSnapshot componentsConfigs = retriever.getConfigs(Set.of(testConfigKey), 0, true);
if (componentsConfigs instanceof ComponentsConfigs) {
assertEquals(3, componentsConfigs.size());
@@ -75,8 +74,8 @@ public class ConfigRetrieverTest {
writeConfigs();
ConfigRetriever retriever = createConfigRetriever();
ConfigKey<? extends ConfigInstance> testConfigKey = new ConfigKey<>(TestConfig.class, dirConfigSource.configId());
- ConfigSnapshot bootstrapConfigs = retriever.getConfigs(Collections.emptySet(), 0, true);
- ConfigSnapshot componentsConfigs = retriever.getConfigs(Collections.singleton(testConfigKey), 0, true);
+ ConfigSnapshot bootstrapConfigs = retriever.getConfigs(Set.of(), 0, true);
+ ConfigSnapshot componentsConfigs = retriever.getConfigs(Set.of(testConfigKey), 0, true);
Set<ConfigKey<? extends ConfigInstance>> keys = new HashSet<>();
keys.add(testConfigKey);
keys.add(new ConfigKey<>(TestConfig.class, ""));
@@ -92,8 +91,8 @@ public class ConfigRetrieverTest {
void require_that_empty_components_keys_after_bootstrap_returns_components_configs() {
writeConfigs();
ConfigRetriever retriever = createConfigRetriever();
- assertTrue(retriever.getConfigs(Collections.emptySet(), 0, true) instanceof BootstrapConfigs);
- assertTrue(retriever.getConfigs(Collections.emptySet(), 0, true) instanceof ComponentsConfigs);
+ assertTrue(retriever.getConfigs(Set.of(), 0, true) instanceof BootstrapConfigs);
+ assertTrue(retriever.getConfigs(Set.of(), 0, true) instanceof ComponentsConfigs);
retriever.shutdown();
}
diff --git a/container-core/src/test/java/com/yahoo/container/handler/threadpool/ContainerThreadPoolImplTest.java b/container-core/src/test/java/com/yahoo/container/handler/threadpool/ContainerThreadPoolImplTest.java
index 3d5375a9740..11de808a415 100644
--- a/container-core/src/test/java/com/yahoo/container/handler/threadpool/ContainerThreadPoolImplTest.java
+++ b/container-core/src/test/java/com/yahoo/container/handler/threadpool/ContainerThreadPoolImplTest.java
@@ -116,7 +116,7 @@ public class ContainerThreadPoolImplTest {
assertEquals(CPUS * 4 * 100, executor.getQueue().remainingCapacity());
}
- private class FlipIt implements Runnable {
+ private static class FlipIt implements Runnable {
public final Receiver<Boolean> didItRun = new Receiver<>();
@Override
@@ -176,7 +176,7 @@ public class ContainerThreadPoolImplTest {
}
}
- private class Hang implements Runnable {
+ private static class Hang implements Runnable {
private final long hangMillis;