diff options
author | Valerij Fredriksen <valerijf@yahooinc.com> | 2022-09-21 13:36:57 +0200 |
---|---|---|
committer | Valerij Fredriksen <valerijf@yahooinc.com> | 2022-09-21 13:36:57 +0200 |
commit | 2b9ed1a5ceabbaf63e615e3acd2a4d9f6be11a3d (patch) | |
tree | 52cc3c82de1ff517a61bb8a7c6834a41f3e72c5f /container-core | |
parent | f81800f066f3291bfd6c3ecbca4a58008ddf9137 (diff) |
Non-functional cleanup
Diffstat (limited to 'container-core')
3 files changed, 3 insertions, 29 deletions
diff --git a/container-core/src/main/java/com/yahoo/container/handler/LogHandler.java b/container-core/src/main/java/com/yahoo/container/handler/LogHandler.java index d151eb6862d..c9dc804c46d 100644 --- a/container-core/src/main/java/com/yahoo/container/handler/LogHandler.java +++ b/container-core/src/main/java/com/yahoo/container/handler/LogHandler.java @@ -4,21 +4,15 @@ package com.yahoo.container.handler; import com.yahoo.component.annotation.Inject; import com.yahoo.container.core.LogHandlerConfig; import com.yahoo.container.jdisc.AsyncHttpResponse; -import com.yahoo.container.jdisc.ContentChannelOutputStream; import com.yahoo.container.jdisc.HttpRequest; import com.yahoo.container.jdisc.ThreadedHttpRequestHandler; import com.yahoo.jdisc.handler.CompletionHandler; import com.yahoo.jdisc.handler.ContentChannel; -import java.io.IOException; -import java.io.InterruptedIOException; import java.io.OutputStream; -import java.nio.ByteBuffer; import java.time.Instant; import java.util.Optional; import java.util.concurrent.Executor; -import java.util.concurrent.atomic.AtomicBoolean; -import java.util.concurrent.atomic.AtomicLong; import java.util.logging.Level; public class LogHandler extends ThreadedHttpRequestHandler { @@ -62,6 +56,4 @@ public class LogHandler extends ThreadedHttpRequestHandler { }; } - - } diff --git a/container-core/src/main/java/com/yahoo/container/handler/LogReader.java b/container-core/src/main/java/com/yahoo/container/handler/LogReader.java index 93881b52eb6..98f9ee3b79e 100644 --- a/container-core/src/main/java/com/yahoo/container/handler/LogReader.java +++ b/container-core/src/main/java/com/yahoo/container/handler/LogReader.java @@ -187,16 +187,7 @@ class LogReader { } - private static class LineWithTimestamp { - final String line; - final double timestamp; - LineWithTimestamp(String line, double timestamp) { - this.line = line; - this.timestamp = timestamp; - } - String line() { return line; } - double timestamp() { return timestamp; } - } + private record LineWithTimestamp(String line, double timestamp) { } /** Returns log files which may have relevant entries, grouped and sorted by {@link #extractTimestamp(Path)} — the first and last group must be filtered. */ private List<List<Path>> getMatchingFiles(Instant from, Instant to) { diff --git a/container-core/src/test/java/com/yahoo/container/handler/LogReaderTest.java b/container-core/src/test/java/com/yahoo/container/handler/LogReaderTest.java index 106b8cef35f..a6db98b6cf5 100644 --- a/container-core/src/test/java/com/yahoo/container/handler/LogReaderTest.java +++ b/container-core/src/test/java/com/yahoo/container/handler/LogReaderTest.java @@ -37,7 +37,7 @@ public class LogReaderTest { @BeforeEach public void setup() throws IOException { - logDirectory = newFolder(folder, "opt/vespa/logs").toPath(); + logDirectory = Files.createDirectories(folder.toPath().resolve("opt/vespa/logs")); // Log archive paths and file names indicate what hour they contain logs for, with the start of that hour. // Multiple entries may exist for each hour. Files.createDirectories(logDirectory.resolve("1970/01/01")); @@ -100,18 +100,9 @@ public class LogReaderTest { return baos.toByteArray(); } - private byte[] compress2(String input) throws IOException { + private byte[] compress2(String input) { byte[] data = input.getBytes(); return new ZstdCompressor().compress(data, 0, data.length); } - private static File newFolder(File root, String... subDirs) throws IOException { - String subFolder = String.join("/", subDirs); - File result = new File(root, subFolder); - if (!result.mkdirs()) { - throw new IOException("Couldn't create folders " + root); - } - return result; - } - } |