diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-09-09 09:19:31 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-09 09:19:31 +0200 |
commit | d944b733f5596aba6141f88288bbc5bb8baa1af2 (patch) | |
tree | 0a0d8fd28372271f39cf1f278a43478985cec07d /container-core | |
parent | f47317e5b67b035a64b1b98e61669861f3a9a3ee (diff) | |
parent | 62ed862f1f66350173a8e0606d2e5f25fab83b93 (diff) |
Merge pull request #23985 from vespa-engine/update-stale-comments
Update stale comments after refactoring the code.
Diffstat (limited to 'container-core')
-rw-r--r-- | container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java b/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java index 88e66c45ca3..cf3db91239a 100644 --- a/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java +++ b/container-core/src/main/java/com/yahoo/container/core/config/ApplicationBundleLoader.java @@ -66,6 +66,9 @@ public class ApplicationBundleLoader { readyForNewBundles = false; } + /** + * Must be called after useBundles() to report success or failure for the latest bundle generation. + */ public synchronized Set<Bundle> completeGeneration(GenerationStatus status) { Set<Bundle> ret = Set.of(); if (readyForNewBundles) return ret; @@ -79,10 +82,8 @@ public class ApplicationBundleLoader { } /** - * Commit to the current set of bundles. Must be called after the component graph creation proved successful, - * to prevent uninstalling bundles unintentionally upon a future call to {@link #revertToPreviousGeneration()}. - * Returns the set of bundles that is no longer used by the application, and should therefore be scheduled - * for uninstall. + * Commit to the latest set of bundles given to useBundles(). Returns the set of bundles that is no longer + * used by the application, and should therefore be scheduled for uninstall. */ private Set<Bundle> commitBundles() { var bundlesToUninstall = new LinkedHashSet<>(obsoleteBundles.values()); |