summaryrefslogtreecommitdiffstats
path: root/container-disc/src/test
diff options
context:
space:
mode:
authorgjoranv <gv@verizonmedia.com>2021-01-26 10:35:40 +0100
committergjoranv <gv@verizonmedia.com>2021-01-26 10:40:33 +0100
commit8038fbd66c920b4847f356111f60aa9e4b44b0ba (patch)
tree29199a9b160e1eb03f0f1cb49a3ce7d2b5a77897 /container-disc/src/test
parent6d4bd3b3b522a199261eb8a92f13f31a67a44186 (diff)
Never provide a StateMetricConsumer.
- It was only provided when MetricsPresentationConfig.slidingwindow was set to false (the config model always adds the JdiscMetricsFactory).
Diffstat (limited to 'container-disc/src/test')
-rw-r--r--container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviderTest.java6
-rw-r--r--container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviders.java10
2 files changed, 1 insertions, 15 deletions
diff --git a/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviderTest.java b/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviderTest.java
index 5e3a49c2dda..0acbb701612 100644
--- a/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviderTest.java
+++ b/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviderTest.java
@@ -34,10 +34,4 @@ public class MetricConsumerProviderTest {
Mockito.verify(bar, Mockito.times(1)).add("foo", 6, null);
}
- @Test
- public void requireThatDefaultConsumerFactoryIsStateMetric() {
- MetricConsumer consumer = MetricConsumerProviders.newDefaultInstance().newInstance();
- assertEquals("StateMetricConsumer", consumer.getClass().getSimpleName());
- }
-
}
diff --git a/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviders.java b/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviders.java
index dd96414bbc7..4e576d2cd8c 100644
--- a/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviders.java
+++ b/container-disc/src/test/java/com/yahoo/container/jdisc/metric/MetricConsumerProviders.java
@@ -22,15 +22,7 @@ class MetricConsumerProviders {
}
public static MetricConsumerProvider newInstance(MetricConsumerFactory... factories) {
- return new MetricConsumerProvider(newComponentRegistry(factories),
- new MetricsPresentationConfig(new MetricsPresentationConfig.Builder()),
- StateMonitor.createForTesting());
- }
-
- public static MetricConsumerProvider newDefaultInstance() {
- return new MetricConsumerProvider(newComponentRegistry(),
- new MetricsPresentationConfig(new MetricsPresentationConfig.Builder()),
- StateMonitor.createForTesting());
+ return new MetricConsumerProvider(newComponentRegistry(factories));
}
public static ComponentRegistry<MetricConsumerFactory> newComponentRegistry(MetricConsumerFactory... factories) {