diff options
author | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2019-02-05 12:55:41 +0100 |
---|---|---|
committer | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2019-02-05 12:55:41 +0100 |
commit | eaa2f5ac24ceae65212d879efc61b6ec4c196942 (patch) | |
tree | fc227ab5c12c81fe125bfdaf685aa9391d57a881 /container-disc | |
parent | 10d2cbe4d7759887eedd302f199eb4cc24875ebe (diff) |
Only report metric when increment is non-zero
Diffstat (limited to 'container-disc')
-rw-r--r-- | container-disc/src/main/java/com/yahoo/container/jdisc/metric/JrtMetrics.java | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/container-disc/src/main/java/com/yahoo/container/jdisc/metric/JrtMetrics.java b/container-disc/src/main/java/com/yahoo/container/jdisc/metric/JrtMetrics.java index 6aa9da3936c..b29d7fe1f21 100644 --- a/container-disc/src/main/java/com/yahoo/container/jdisc/metric/JrtMetrics.java +++ b/container-disc/src/main/java/com/yahoo/container/jdisc/metric/JrtMetrics.java @@ -24,12 +24,18 @@ class JrtMetrics { void emitMetrics() { Snapshot snapshot = transportMetrics.snapshot(); Snapshot changesSincePrevious = snapshot.changesSince(previousSnapshot); - metric.add("jrt.transport.tls-certificate-verification-failures", changesSincePrevious.tlsCertificateVerificationFailures(), null); - metric.add("jrt.transport.peer-authorization-failures", changesSincePrevious.peerAuthorizationFailures(), null); - metric.add("jrt.transport.server.tls-connections-established", changesSincePrevious.serverTlsConnectionsEstablished(), null); - metric.add("jrt.transport.client.tls-connections-established", changesSincePrevious.clientTlsConnectionsEstablished(), null); - metric.add("jrt.transport.server.unencrypted-connections-established", changesSincePrevious.serverUnencryptedConnectionsEstablished(), null); - metric.add("jrt.transport.client.unencrypted-connections-established", changesSincePrevious.clientUnencryptedConnectionsEstablished(), null); + increment("jrt.transport.tls-certificate-verification-failures", changesSincePrevious.tlsCertificateVerificationFailures()); + increment("jrt.transport.peer-authorization-failures", changesSincePrevious.peerAuthorizationFailures()); + increment("jrt.transport.server.tls-connections-established", changesSincePrevious.serverTlsConnectionsEstablished()); + increment("jrt.transport.client.tls-connections-established", changesSincePrevious.clientTlsConnectionsEstablished()); + increment("jrt.transport.server.unencrypted-connections-established", changesSincePrevious.serverUnencryptedConnectionsEstablished()); + increment("jrt.transport.client.unencrypted-connections-established", changesSincePrevious.clientUnencryptedConnectionsEstablished()); previousSnapshot = snapshot; } + + private void increment(String metricName, long countIncrement) { + if (countIncrement > 0) { + metric.add(metricName, countIncrement, null); + } + } } |