diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2022-01-07 19:48:27 +0100 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2022-01-07 19:48:27 +0100 |
commit | f481487c49e3ffd5119f9d5b0df53345e8083f33 (patch) | |
tree | eff248d7ae5acc2bd63590b6cfd21be8271b9e1d /container-messagebus | |
parent | 773b475bd018104200391de380e9f570454faa19 (diff) |
After we close a MBusServer we are not busy, retrying will not make life better.
Shutdown is a better error code.
Diffstat (limited to 'container-messagebus')
-rw-r--r-- | container-messagebus/src/main/java/com/yahoo/messagebus/jdisc/MbusServer.java | 4 | ||||
-rw-r--r-- | container-messagebus/src/test/java/com/yahoo/messagebus/jdisc/MbusServerConformanceTest.java | 4 |
2 files changed, 3 insertions, 5 deletions
diff --git a/container-messagebus/src/main/java/com/yahoo/messagebus/jdisc/MbusServer.java b/container-messagebus/src/main/java/com/yahoo/messagebus/jdisc/MbusServer.java index 084a5f82268..9a8dda246a0 100644 --- a/container-messagebus/src/main/java/com/yahoo/messagebus/jdisc/MbusServer.java +++ b/container-messagebus/src/main/java/com/yahoo/messagebus/jdisc/MbusServer.java @@ -75,9 +75,7 @@ public final class MbusServer extends AbstractResource implements ServerProvider return; } if (state == State.STOPPED) { - // We might need to detect requests originating from the same JVM, as they need to fail fast - // as they are holding references to the container preventing proper shutdown. - dispatchErrorReply(msg, ErrorCode.SESSION_BUSY, "MBusServer has been closed."); + dispatchErrorReply(msg, ErrorCode.NETWORK_SHUTDOWN, "MBusServer has been closed."); return; } if (msg.getTrace().shouldTrace(6)) { diff --git a/container-messagebus/src/test/java/com/yahoo/messagebus/jdisc/MbusServerConformanceTest.java b/container-messagebus/src/test/java/com/yahoo/messagebus/jdisc/MbusServerConformanceTest.java index 397a3eb5242..4ef26534a92 100644 --- a/container-messagebus/src/test/java/com/yahoo/messagebus/jdisc/MbusServerConformanceTest.java +++ b/container-messagebus/src/test/java/com/yahoo/messagebus/jdisc/MbusServerConformanceTest.java @@ -30,7 +30,7 @@ import java.util.concurrent.LinkedBlockingDeque; import java.util.concurrent.TimeUnit; import static com.yahoo.messagebus.ErrorCode.APP_FATAL_ERROR; -import static com.yahoo.messagebus.ErrorCode.SESSION_BUSY; +import static com.yahoo.messagebus.ErrorCode.NETWORK_SHUTDOWN; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotNull; @@ -50,7 +50,7 @@ public class MbusServerConformanceTest extends ServerProviderConformanceTest { @Test public void testContainerNotReadyException() throws Throwable { new TestRunner().setRequestTimeout(100, TimeUnit.MILLISECONDS) - .expectError(SESSION_BUSY) + .expectError(NETWORK_SHUTDOWN) .executeAndClose(); } |