summaryrefslogtreecommitdiffstats
path: root/container-search/src/main/java/com/yahoo/search/cluster
diff options
context:
space:
mode:
authorjonmv <venstad@gmail.com>2023-07-10 19:50:56 +0200
committerjonmv <venstad@gmail.com>2023-07-13 10:30:49 +0200
commit4e19b88dde87c8186bde9ae9def6c0f24a87f784 (patch)
tree819094071196405f421d50296d1aaee4dda01e7c /container-search/src/main/java/com/yahoo/search/cluster
parente2e7fc4f5c49451a210ca681416c848cb9ed7377 (diff)
Simplify a bit
Diffstat (limited to 'container-search/src/main/java/com/yahoo/search/cluster')
-rw-r--r--container-search/src/main/java/com/yahoo/search/cluster/ClusterMonitor.java12
-rw-r--r--container-search/src/main/java/com/yahoo/search/cluster/ClusterSearcher.java2
2 files changed, 4 insertions, 10 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/cluster/ClusterMonitor.java b/container-search/src/main/java/com/yahoo/search/cluster/ClusterMonitor.java
index 0b627e91bc5..d66b6637cd3 100644
--- a/container-search/src/main/java/com/yahoo/search/cluster/ClusterMonitor.java
+++ b/container-search/src/main/java/com/yahoo/search/cluster/ClusterMonitor.java
@@ -96,20 +96,14 @@ public class ClusterMonitor<T> {
* Ping all nodes which needs pinging to discover state changes
*/
public void ping(Executor executor) {
- for (Iterator<BaseNodeMonitor<T>> i = nodeMonitorIterator(); i.hasNext() && !closed.get(); ) {
- BaseNodeMonitor<T> monitor= i.next();
- nodeManager.ping(this, monitor.getNode(), executor); // Cause call to failed or responded
+ for (var monitor : nodeMonitors()) {
+ if (closed.get()) return; // Do nothing to change state if close has started.
+ nodeManager.ping(this, monitor.getNode(), executor);
}
- if (closed.get()) return; // Do nothing to change state if close has started.
nodeManager.pingIterationCompleted();
}
/** Returns a thread-safe snapshot of the NodeMonitors of all added nodes */
- public Iterator<BaseNodeMonitor<T>> nodeMonitorIterator() {
- return nodeMonitors().iterator();
- }
-
- /** Returns a thread-safe snapshot of the NodeMonitors of all added nodes */
public List<BaseNodeMonitor<T>> nodeMonitors() {
return List.copyOf(nodeMonitors.values());
}
diff --git a/container-search/src/main/java/com/yahoo/search/cluster/ClusterSearcher.java b/container-search/src/main/java/com/yahoo/search/cluster/ClusterSearcher.java
index 4af6757db8c..1cf36d75fc5 100644
--- a/container-search/src/main/java/com/yahoo/search/cluster/ClusterSearcher.java
+++ b/container-search/src/main/java/com/yahoo/search/cluster/ClusterSearcher.java
@@ -48,7 +48,7 @@ public abstract class ClusterSearcher<T> extends PingableSearcher implements Nod
*
* @param id the id of this searcher
* @param connections the connections of the cluster
- * @param internal whether or not this cluster is internal (part of the same installation)
+ * @param internal whether this cluster is internal (part of the same installation)
*/
public ClusterSearcher(ComponentId id, List<T> connections, boolean internal) {
this(id, connections, new Hasher<>(), internal);