diff options
author | Jon Bratseth <bratseth@oath.com> | 2018-08-14 11:15:12 +0200 |
---|---|---|
committer | Jon Bratseth <bratseth@oath.com> | 2018-08-14 11:15:12 +0200 |
commit | 7b134d8ef30cc3bd6e0867ba3f47452d78d4fce0 (patch) | |
tree | 96ef67d3c9998c0f51c289d1e8cfb298b26f0e2f /container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java | |
parent | 216feb84a135cbcd3e20cdb3240a63fdb53439e3 (diff) |
Fix Select and grouping bugs
- Deep copy the grouping structure on query copy.
It is mutable but we have neglected doing this right until now.
- Fix a bug in the previous commit where the last constructed Query.Model was shared between all instances.
- Fix a bug in the previous commit where the query string instead of the query tree was reset when a new select
expression is set.
- Don't use deprecated method.
- Clean up Javadoc and formatting.
Diffstat (limited to 'container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java')
-rw-r--r-- | container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java b/container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java index f66492f87ad..003ef9c6a00 100644 --- a/container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java +++ b/container-search/src/main/java/com/yahoo/search/grouping/request/MathTanFunction.java @@ -5,14 +5,26 @@ import java.util.Arrays; /** * @author baldersheim + * @author bratseth */ public class MathTanFunction extends FunctionNode { + /** * Constructs a new instance of this class. * * @param exp The expression to evaluate, double value will be requested. */ public MathTanFunction(GroupingExpression exp) { - super("math.tan", Arrays.asList(exp)); + this(null, null, exp); + } + + private MathTanFunction(String label, Integer level, GroupingExpression exp) { + super("math.tan", label, level, Arrays.asList(exp)); } + + @Override + public MathTanFunction copy() { + return new MathTanFunction(getLabel(), getLevelOrNull(), getArg(0).copy()); + } + } |