summaryrefslogtreecommitdiffstats
path: root/container-search/src/main/java/com/yahoo/search/handler
diff options
context:
space:
mode:
authorHenrik <henrik.hoiness@online.no>2018-08-07 12:16:54 +0200
committerHenrik <henrik.hoiness@online.no>2018-08-07 12:16:54 +0200
commitdfca30f3691a3a637fb5ee34000126c597f5f6aa (patch)
treedee514e4de9c8f2293a043baf18d2d7c4a415af2 /container-search/src/main/java/com/yahoo/search/handler
parenta9ce32c11684e612d5bf68686ee21414677d01ee (diff)
Changes from review.
Diffstat (limited to 'container-search/src/main/java/com/yahoo/search/handler')
-rw-r--r--container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java7
1 files changed, 3 insertions, 4 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java b/container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java
index c9e723db6d0..5ac1f834031 100644
--- a/container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java
+++ b/container-search/src/main/java/com/yahoo/search/handler/SearchHandler.java
@@ -586,10 +586,9 @@ public class SearchHandler extends LoggingRequestHandler {
throw new QueryException("Illegal query: Query contains both yql- and select-parameter");
}
- // The query-parameter overrides the select-parameter. Removing them here to prevent further processing of select-parameters.
- if (requestMap.containsKey("query")) {
- requestMap.remove("select.where");
- requestMap.remove("select.grouping");
+ // Throws QueryException if query contains both query- and select-parameter
+ if (requestMap.containsKey("query") && (requestMap.containsKey("select.where") || requestMap.containsKey("select.grouping")) ) {
+ throw new QueryException("Illegal query: Query contains both query- and select-parameter");
}
return requestMap;