Skip logging only for IllegalInputException

- Add IllegalInputException to signal cases where we know the exception
  is caused by illegal input received from the requestor.
- Only skip logging for IllegalInputException instead of the superclass
  IllegalArgumentException as that is also used to signal illegal
  arguments to methods due to bugs which are otherwise hard to debug.
- Throw IllegalInputException rather than IllegalArgumentException
  where appropriate.
- Deprecated QueryException as it was only used to be able to separate
  between query string and query parameter exceptions, and not doing
  that consistently, and is in a package we don't want more use of.
- Clean up some cases where the wrong exception was thrown.

1 files changed, 3 insertions, 1 deletions

diff --git a/container-search/src/main/java/com/yahoo/search/query/textserialize/item/ItemContext.java b/container-search/src/main/java/com/yahoo/search/query/textserialize/item/ItemContext.java
index e739608387d..b6c886c91d7 100644
--- a/container-search/src/main/java/com/yahoo/search/query/textserialize/item/ItemContext.java
+++ b/container-search/src/main/java/com/yahoo/search/query/textserialize/item/ItemContext.java
@@ -12,6 +12,7 @@ import java.util.Map;
  * @author Tony Vaagenes
  */
 public class ItemContext {
+
     private class Connectivity {
         final String id;
         final double strength;
@@ -43,7 +44,8 @@ public class ItemContext {
     private Item getItem(String id) {
         Item item = itemById.get(id);
         if (item == null)
-            throw new IllegalArgumentException("No item with id '" + id + "'.");
+            throw new IllegalArgumentException("No item with id '" + id + "'");
         return item;
     }
+
 }