aboutsummaryrefslogtreecommitdiffstats
path: root/container-search/src/main/java/com/yahoo/search
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2023-10-10 23:09:27 +0200
committerHenning Baldersheim <balder@yahoo-inc.com>2023-10-10 23:09:27 +0200
commit6523c732b3e5b61d45e5e60ef0cfe6b2e8876a7b (patch)
treeee4ae64ad3ba9544a525aec618f6cc4034985dd3 /container-search/src/main/java/com/yahoo/search
parentfa097b1bc57e882be261cda2145f0bbf2452eaaa (diff)
- Prevent adding your own errors to self.
- Prevents both duplication and modifying the list you are iterating, with the unpleasant ConcurrenModificationException.
Diffstat (limited to 'container-search/src/main/java/com/yahoo/search')
-rw-r--r--container-search/src/main/java/com/yahoo/search/result/DefaultErrorHit.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/result/DefaultErrorHit.java b/container-search/src/main/java/com/yahoo/search/result/DefaultErrorHit.java
index 5fd41be0a54..fdd5c79adb6 100644
--- a/container-search/src/main/java/com/yahoo/search/result/DefaultErrorHit.java
+++ b/container-search/src/main/java/com/yahoo/search/result/DefaultErrorHit.java
@@ -75,6 +75,7 @@ public class DefaultErrorHit extends Hit implements ErrorHit, Cloneable {
/** Add all errors from another error hit to this */
public void addErrors(ErrorHit errorHit) {
+ if (this == errorHit) return;
for (Iterator<? extends ErrorMessage> i = errorHit.errorIterator(); i.hasNext();) {
addError(i.next());
}