diff options
author | Henning Baldersheim <balder@yahoo-inc.com> | 2019-09-06 15:55:33 +0200 |
---|---|---|
committer | Henning Baldersheim <balder@yahoo-inc.com> | 2019-09-06 15:55:33 +0200 |
commit | 3ac5feb050cb4564458783b9696b02f414a171e5 (patch) | |
tree | 6e29c2dd97427e3522a5ab31201aeaac1344fccf /container-search/src/main/java/com/yahoo/search | |
parent | 48cc0d894e3225a3b447698711a60fe196d88438 (diff) |
Add comments and more clear error messages.
Diffstat (limited to 'container-search/src/main/java/com/yahoo/search')
-rw-r--r-- | container-search/src/main/java/com/yahoo/search/yql/MinimalQueryInserter.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/yql/MinimalQueryInserter.java b/container-search/src/main/java/com/yahoo/search/yql/MinimalQueryInserter.java index 3ce728429c1..21f8c15fdd4 100644 --- a/container-search/src/main/java/com/yahoo/search/yql/MinimalQueryInserter.java +++ b/container-search/src/main/java/com/yahoo/search/yql/MinimalQueryInserter.java @@ -44,6 +44,7 @@ public class MinimalQueryInserter extends Searcher { @Inject public MinimalQueryInserter(Linguistics linguistics) { + // Warmup is needed to avoid a large 400ms init cost during first execution of yql code. warmup(linguistics); } MinimalQueryInserter() { @@ -52,15 +53,15 @@ public class MinimalQueryInserter extends Searcher { static boolean warmup() { return warmup(new SimpleLinguistics()); } - static boolean warmup(Linguistics linguistics) { + private static boolean warmup(Linguistics linguistics) { Query query = new Query("search/?yql=select%20*%20from%20sources%20where%20title%20contains%20'xyz';"); Result result = insertQuery(query, new ParserEnvironment().setLinguistics(linguistics)); if (result != null) { - log.warning("Something fishy. Reult = " + result.toString()); + log.warning("Warmup code trigger an error. Error = " + result.toString()); return false; } if ( ! "select * from sources where title contains \"xyz\";".equals(query.yqlRepresentation())) { - log.warning("Unexpected yql: " + query.yqlRepresentation()); + log.warning("Warmup code generated unexpected yql: " + query.yqlRepresentation()); return false; } return true; |