diff options
author | Jon Bratseth <bratseth@gmail.com> | 2022-03-15 11:26:52 +0100 |
---|---|---|
committer | Jon Bratseth <bratseth@gmail.com> | 2022-03-15 11:26:52 +0100 |
commit | a0ce45b48fb249aa8225825a57ac051b31dcf839 (patch) | |
tree | 602a3badaf662e91ea8d3d11c5b771a0e9020d44 /container-search/src/main/java | |
parent | b1015bd850fb94157d8c21077578e45628384e02 (diff) |
Improve 'not balanced' info message
Diffstat (limited to 'container-search/src/main/java')
4 files changed, 8 insertions, 8 deletions
diff --git a/container-search/src/main/java/com/yahoo/fs4/MapEncoder.java b/container-search/src/main/java/com/yahoo/fs4/MapEncoder.java index 9dc3734f157..c0ca9466100 100644 --- a/container-search/src/main/java/com/yahoo/fs4/MapEncoder.java +++ b/container-search/src/main/java/com/yahoo/fs4/MapEncoder.java @@ -86,7 +86,6 @@ public class MapEncoder { * * Returns the number of maps encoded - 0 or 1 */ - public static <T> int encodeMultiMap(String mapName, Map<String,List<T>> map, ByteBuffer buffer) { if (map.isEmpty()) return 0; diff --git a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java index e99c1d5ad32..5e12fb550c8 100644 --- a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java +++ b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java @@ -17,7 +17,7 @@ import java.util.logging.Logger; public class Group { private static final Logger log = Logger.getLogger(Group.class.getName()); - private final static double maxContentSkew = 0.10; // If documents on a node is more than 10% off from the average the group is unbalanced + private final static double maxContentSkew = 0.10; private final static int minDocsPerNodeToRequireLowSkew = 100; private final int id; @@ -77,8 +77,9 @@ public class Group { if (!isBalanced.get() || balanced != isBalanced.get()) { if (!isSparse()) log.info("Content in " + this + ", with " + numWorkingNodes + "/" + nodes.size() + " working nodes, is " + - (balanced ? "" : "not ") + "well balanced. Current deviation = " + skew * 100 / activeDocs + - " %. activeDocs = " + activeDocs + ", skew = " + skew + ", average = " + average); + (balanced ? "" : "not ") + "well balanced. Current deviation: " + skew * 100 / activeDocs + + "%. Active documents: " + activeDocs + ", skew: " + skew + ", average: " + average + + (balanced ? "" : ". Top-k summary fetch optimization is deactivated.")); isBalanced.set(balanced); } } else { diff --git a/container-search/src/main/java/com/yahoo/search/query/Ranking.java b/container-search/src/main/java/com/yahoo/search/query/Ranking.java index ee61a151f66..a5f4d3e37ff 100644 --- a/container-search/src/main/java/com/yahoo/search/query/Ranking.java +++ b/container-search/src/main/java/com/yahoo/search/query/Ranking.java @@ -255,7 +255,7 @@ public class Ranking implements Cloneable { /** Sets sorting from a string. See {@link Sorting} on syntax */ public void setSorting(String sortingString) { - if (sortingString==null) + if (sortingString == null) setSorting((Sorting)null); else setSorting(new Sorting(sortingString)); diff --git a/container-search/src/main/java/com/yahoo/search/query/ranking/RankProperties.java b/container-search/src/main/java/com/yahoo/search/query/ranking/RankProperties.java index 2c16c56db3a..f0159eae1fd 100644 --- a/container-search/src/main/java/com/yahoo/search/query/ranking/RankProperties.java +++ b/container-search/src/main/java/com/yahoo/search/query/ranking/RankProperties.java @@ -13,14 +13,14 @@ import java.util.List; import java.util.Map; /** - * Contains the properties properties of a query. + * Contains the properties of a query. * This is a multimap: Multiple properties may be set for the same key. * * @author bratseth */ public class RankProperties implements Cloneable { - private Map<String, List<Object>> properties; + private final Map<String, List<Object>> properties; public RankProperties() { this(new LinkedHashMap<>()); @@ -61,7 +61,7 @@ public class RankProperties implements Cloneable { return Collections.unmodifiableList(stringValues); } - /** Removes all properties properties for a given name */ + /** Removes all properties for a given name */ public void remove(String name) { properties.remove(name); } |