diff options
author | Arne Juul <arnej@yahooinc.com> | 2023-03-06 09:56:12 +0000 |
---|---|---|
committer | Arne Juul <arnej@yahooinc.com> | 2023-03-06 09:56:12 +0000 |
commit | 056a6275375575e01dbb0a73867ae379bcbd57e0 (patch) | |
tree | 84e8970378fcbfa5b295bca8f028efc972ffabe4 /container-search | |
parent | e22467e6500b212a611827659d79b680f1b7f805 (diff) |
use same criteria for rescale as second-phase does
Diffstat (limited to 'container-search')
-rw-r--r-- | container-search/src/main/java/com/yahoo/search/ranking/ResultReranker.java | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/ranking/ResultReranker.java b/container-search/src/main/java/com/yahoo/search/ranking/ResultReranker.java index 11b3fa7390a..8d24acdf141 100644 --- a/container-search/src/main/java/com/yahoo/search/ranking/ResultReranker.java +++ b/container-search/src/main/java/com/yahoo/search/ranking/ResultReranker.java @@ -23,8 +23,10 @@ class ResultReranker { private double finalScores_high = -Double.MAX_VALUE; private double finalScores_low = Double.MAX_VALUE; - boolean valid() { - return (initialScores_high >= initialScores_low + boolean rescaleNeeded() { + return (initialScores_low > finalScores_low + && + initialScores_high >= initialScores_low && finalScores_high >= finalScores_low); } @@ -76,8 +78,8 @@ class ResultReranker { iterator.remove(); } } - // if any hits are left in the list, they need rescaling: - if (ranges.valid()) { + // if any hits are left in the list, they may need rescaling: + if (ranges.rescaleNeeded()) { double scale = ranges.scale(); double bias = ranges.bias(); for (Hit hit : hitsToRescore) { |