diff options
author | Arne H Juul <arnej@yahoo-inc.com> | 2017-04-25 15:59:29 +0200 |
---|---|---|
committer | Arne H Juul <arnej@yahoo-inc.com> | 2017-04-26 09:29:15 +0200 |
commit | e5b764488515115b84caa593744c3c1a7ce9d86f (patch) | |
tree | e951084903b73bd3b2663b396cbb35afcc1d0ad7 /container-search | |
parent | 60959a0368a1cfedf42bb2a970ee8adf8792a417 (diff) |
suppress fallthrough warnings
* add comments where they occurred, somebody should look at that
Diffstat (limited to 'container-search')
-rw-r--r-- | container-search/src/main/java/com/yahoo/prelude/query/parser/Tokenizer.java | 2 | ||||
-rw-r--r-- | container-search/src/main/java/com/yahoo/search/yql/ProgramParser.java | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/container-search/src/main/java/com/yahoo/prelude/query/parser/Tokenizer.java b/container-search/src/main/java/com/yahoo/prelude/query/parser/Tokenizer.java index ed0af8d5060..9ce98055335 100644 --- a/container-search/src/main/java/com/yahoo/prelude/query/parser/Tokenizer.java +++ b/container-search/src/main/java/com/yahoo/prelude/query/parser/Tokenizer.java @@ -166,6 +166,7 @@ public final class Tokenizer { return tokens; } + @SuppressWarnings("fallthrough") private boolean acceptApostropheAsWordCharacter(Index currentIndex) { if (!(currentIndex.isUriIndex() || currentIndex.isHostIndex())) { return true; @@ -178,6 +179,7 @@ public final class Tokenizer { if (i == indexLastExplicitlyChangedAt) { return false; } + // XXX was fallthrough intended here? case SPACE: return true; default: diff --git a/container-search/src/main/java/com/yahoo/search/yql/ProgramParser.java b/container-search/src/main/java/com/yahoo/search/yql/ProgramParser.java index a4cfa24fd5e..a83f1f9c941 100644 --- a/container-search/src/main/java/com/yahoo/search/yql/ProgramParser.java +++ b/container-search/src/main/java/com/yahoo/search/yql/ProgramParser.java @@ -112,6 +112,7 @@ import java.util.Set; /** * Translate the ANTLR grammar into the logical representation. */ +@SuppressWarnings("fallthrough") final class ProgramParser { public yqlplusParser prepareParser(String programName, InputStream input) throws IOException { @@ -713,7 +714,7 @@ final class ProgramParser { switch (getParseTreeIndex(dataSourceNode)) { case yqlplusParser.RULE_write_data_source: case yqlplusParser.RULE_call_source: { - List<String> names = readName((Namespaced_nameContext)dataSourceNode.getChild(Namespaced_nameContext.class, 0)); + List<String> names = readName(dataSourceNode.getChild(Namespaced_nameContext.class, 0)); alias = assignAlias(names.get(names.size() - 1), aliasContext, scope); List<OperatorNode<ExpressionOperator>> arguments = ImmutableList.of(); ArgumentsContext argumentsContext = dataSourceNode.getRuleContext(ArgumentsContext.class,0); @@ -874,6 +875,7 @@ final class ProgramParser { // DDL case yqlplusParser.RULE_ddl: ruleContext = (ParserRuleContext)ruleContext.getChild(0); + // XXX was fallthrough intended here? case yqlplusParser.RULE_view: { // view and projection expansion now has to be done by the // execution engine @@ -1122,6 +1124,8 @@ final class ProgramParser { return convertExpr(parseTree.getChild(1), scope); } } + // XXX was fallthrough intended here? probably not. + // TODO: Temporarily disable CAST - think through how types are named // case yqlplusParser.CAST: { // |