summaryrefslogtreecommitdiffstats
path: root/container-search
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2021-01-08 14:42:20 +0000
committerHenning Baldersheim <balder@yahoo-inc.com>2021-01-08 14:43:42 +0000
commitf9f249d32a7b7514806d250b8f77eea1a086dde8 (patch)
tree468846d43336c07cd65d6c6bc01c4591468e3539 /container-search
parentc07f7df456d48ab8f58810ac0033c48488f82de5 (diff)
- Call getAsInt.....
- Add some debug logging.
Diffstat (limited to 'container-search')
-rw-r--r--container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java6
-rw-r--r--container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java2
2 files changed, 5 insertions, 3 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java
index be98ac57fc5..24caab75b32 100644
--- a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java
+++ b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/Group.java
@@ -69,8 +69,10 @@ public class Group {
long average = activeDocs / numWorkingNodes;
long deviation = nodes.stream().filter(node -> node.isWorking() == Boolean.TRUE).mapToLong(node -> Math.abs(node.getActiveDocuments() - average)).sum();
boolean isDeviationSmall = deviation <= (activeDocs * MAX_UNBALANCE);
- if (isDeviationSmall != isContentWellBalanced.get()) {
- log.info("Content is well balanced has changed to" + isDeviationSmall);
+ if ((!isContentWellBalanced.get() || isDeviationSmall != isContentWellBalanced.get()) && (activeDocs > 0)) {
+ log.info("Content is " + (isDeviationSmall ? "" : "not") + " well balanced has changed to " + isDeviationSmall +
+ ". Current deviation = " + deviation*100/activeDocs + " %" +
+ ". activeDocs = " + activeDocs + ", deviation = " + deviation + ", average = " + average);
isContentWellBalanced.set(isDeviationSmall);
}
} else {
diff --git a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java
index 56165ec150b..1897c0af8bc 100644
--- a/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java
+++ b/container-search/src/main/java/com/yahoo/search/dispatch/searchcluster/SearchCluster.java
@@ -370,7 +370,7 @@ public class SearchCluster implements NodeManager<Node> {
public boolean isGroupWellBalanced(OptionalInt groupId) {
if (groupId.isEmpty()) return false;
- Group group = groups().get(groupId);
+ Group group = groups().get(groupId.getAsInt());
return (group != null) && group.isContentWellBalanced();
}