Relax validation of nearest neighbor searcher (java).

Relax validation of nearest neighbor iterator (C++).

2 files changed, 41 insertions, 15 deletions

diff --git a/container-search/src/main/java/com/yahoo/search/searchers/ValidateNearestNeighborSearcher.java b/container-search/src/main/java/com/yahoo/search/searchers/ValidateNearestNeighborSearcher.java
index 25d0e184588..06c551692fb 100644
--- a/container-search/src/main/java/com/yahoo/search/searchers/ValidateNearestNeighborSearcher.java
+++ b/container-search/src/main/java/com/yahoo/search/searchers/ValidateNearestNeighborSearcher.java
@@ -79,17 +79,32 @@ public class ValidateNearestNeighborSearcher extends Searcher {
             return true;
         }
 
-        private static boolean isCompatible(TensorType lhs, TensorType rhs) {
-            return lhs.dimensions().equals(rhs.dimensions());
+        private static boolean isCompatible(TensorType fieldTensorType, TensorType queryTensorType) {
+            // Precondition: isTensorTypeThatSupportsHnswIndex(fieldTensorType)
+            var queryDimensions = queryTensorType.dimensions();
+            if (queryDimensions.size() == 1) {
+                var queryDimension = queryDimensions.get(0);
+                var fieldDimensions = fieldTensorType.dimensions();
+                for (var fieldDimension : fieldDimensions) {
+                    if (fieldDimension.isIndexed()) {
+                        return fieldDimension.equals(queryDimension);
+                    }
+                }
+            }
+            return false;
         }
 
-        private static boolean isDenseVector(TensorType tt) {
+        private static boolean isTensorTypeThatSupportsHnswIndex(TensorType tt) {
             List<TensorType.Dimension> dims = tt.dimensions();
-            if (dims.size() != 1) return false;
-            for (var d : dims) {
-                if (d.type() != TensorType.Dimension.Type.indexedBound) return false;
+            if (dims.size() == 1) {
+                return dims.get(0).isIndexed();
             }
-            return true;
+            if (dims.size() == 2) {
+                var dims0 = dims.get(0);
+                var dims1 = dims.get(1);
+                return ((dims0.isMapped() && dims1.isIndexed()) || (dims0.isIndexed() && dims1.isMapped()));
+            }
+            return false;
         }
 
         /** Returns an error message if this is invalid, or null if it is valid */
@@ -107,18 +122,18 @@ public class ValidateNearestNeighborSearcher extends Searcher {
             }
             List<TensorType> allTensorTypes = validAttributes.get(item.getIndexName());
             for (TensorType fieldType : allTensorTypes) {
-                if (isDenseVector(fieldType) && isCompatible(fieldType, queryTensor.get().type())) {
+                if (isTensorTypeThatSupportsHnswIndex(fieldType) && isCompatible(fieldType, queryTensor.get().type())) {
                     return null;
                 }
             }
             for (TensorType fieldType : allTensorTypes) {
-                if (isDenseVector(fieldType) && ! isCompatible(fieldType, queryTensor.get().type())) {
+                if (isTensorTypeThatSupportsHnswIndex(fieldType) && ! isCompatible(fieldType, queryTensor.get().type())) {
                     return item + " field type " + fieldType + " does not match query type " + queryTensor.get().type();
                 }
             }
             for (TensorType fieldType : allTensorTypes) {
-                if (! isDenseVector(fieldType)) {
-                    return item + " tensor type " + fieldType + " is not a dense vector";
+                if (! isTensorTypeThatSupportsHnswIndex(fieldType)) {
+                    return item + " field type " + fieldType + " is not supported by nearest neighbor searcher";
                 }
             }
             return item + " field is not a tensor";
diff --git a/container-search/src/test/java/com/yahoo/search/searchers/ValidateNearestNeighborTestCase.java b/container-search/src/test/java/com/yahoo/search/searchers/ValidateNearestNeighborTestCase.java
index b8be0b3dd43..9a7e3915d19 100644
--- a/container-search/src/test/java/com/yahoo/search/searchers/ValidateNearestNeighborTestCase.java
+++ b/container-search/src/test/java/com/yahoo/search/searchers/ValidateNearestNeighborTestCase.java
@@ -33,7 +33,7 @@ public class ValidateNearestNeighborTestCase {
         searcher = new ValidateNearestNeighborSearcher(
                 ConfigGetter.getConfig(AttributesConfig.class,
                                        "raw:" +
-                                                     "attribute[5]\n" +
+                                                     "attribute[9]\n" +
                                                      "attribute[0].name                simple\n" +
                                                      "attribute[0].datatype            INT32\n" +
                                                      "attribute[1].name                dvector\n" +
@@ -56,7 +56,10 @@ public class ValidateNearestNeighborTestCase {
                                                      "attribute[6].tensortype          tensor(x[3])\n" +
                                                      "attribute[7].name                threetypes\n" +
                                                      "attribute[7].datatype            TENSOR\n" +
-                                                     "attribute[7].tensortype          tensor(x{})\n"
+                                                     "attribute[7].tensortype          tensor(x{})\n" +
+                                                     "attribute[8].name                mixeddvector\n" +
+                                                     "attribute[8].datatype            TENSOR\n" +
+                                                     "attribute[8].tensortype          tensor(a{},x[3])\n"
         ));
     }
 
@@ -134,6 +137,14 @@ public class ValidateNearestNeighborTestCase {
         assertNull(r.hits().getError());
     }
 
+    @Test
+    void testvalidQueryMixedFieldTensor() {
+        String q = makeQuery("mixeddvector", "qvector");
+        Tensor t = makeTensor(tt_dense_dvector_3);
+        Result r = doSearch(searcher, q, t);
+        assertNull(r.hits().getError());
+    }
+
     private static void assertErrMsg(String message, Result r) {
         assertEquals(ErrorMessage.createIllegalQuery(message), r.hits().getError());
     }
@@ -210,7 +221,7 @@ public class ValidateNearestNeighborTestCase {
         String q = makeQuery("sparse", "qvector");
         Tensor t = makeTensor(tt_sparse_vector_x);
         Result r = doSearch(searcher, q, t);
-        assertErrMsg(desc("sparse", "qvector", 1, "tensor type tensor(x{}) is not a dense vector"), r);
+        assertErrMsg(desc("sparse", "qvector", 1, "field type tensor(x{}) is not supported by nearest neighbor searcher"), r);
     }
 
     @Test
@@ -218,7 +229,7 @@ public class ValidateNearestNeighborTestCase {
         String q = makeQuery("matrix", "qvector");
         Tensor t = makeMatrix(tt_dense_matrix_xy);
         Result r = doSearch(searcher, q, t);
-        assertErrMsg(desc("matrix", "qvector", 1, "tensor type tensor(x[3],y[1]) is not a dense vector"), r);
+        assertErrMsg(desc("matrix", "qvector", 1, "field type tensor(x[3],y[1]) is not supported by nearest neighbor searcher"), r);
     }
 
     private static Result doSearch(ValidateNearestNeighborSearcher searcher, String yqlQuery, Tensor qTensor) {