summaryrefslogtreecommitdiffstats
path: root/container-search
diff options
context:
space:
mode:
authorHenning Baldersheim <balder@yahoo-inc.com>2019-03-20 19:11:12 +0100
committerHenning Baldersheim <balder@yahoo-inc.com>2019-03-20 19:11:12 +0100
commitf60935d45bd01a0e0edfa5dc605936ad96f88aaa (patch)
tree818104eaddfcddf670be976232ed6df1c6a393fc /container-search
parent484c21d1f176e60aef41cf336004e41b9160f174 (diff)
Soft timeout is now default in backend. No need to send down properties anymore.
Diffstat (limited to 'container-search')
-rw-r--r--container-search/src/main/java/com/yahoo/search/query/ranking/SoftTimeout.java5
-rw-r--r--container-search/src/test/java/com/yahoo/fs4/test/QueryTestCase.java5
-rw-r--r--container-search/src/test/java/com/yahoo/prelude/fastsearch/test/FastSearcherTestCase.java1
-rw-r--r--container-search/src/test/java/com/yahoo/search/query/SoftTimeoutTestCase.java4
4 files changed, 6 insertions, 9 deletions
diff --git a/container-search/src/main/java/com/yahoo/search/query/ranking/SoftTimeout.java b/container-search/src/main/java/com/yahoo/search/query/ranking/SoftTimeout.java
index 5132d954687..05cbed6b6d9 100644
--- a/container-search/src/main/java/com/yahoo/search/query/ranking/SoftTimeout.java
+++ b/container-search/src/main/java/com/yahoo/search/query/ranking/SoftTimeout.java
@@ -69,9 +69,8 @@ public class SoftTimeout implements Cloneable {
/** Internal operation - DO NOT USE */
public void prepare(RankProperties rankProperties) {
- if ( !enabled) return;
-
- rankProperties.put("vespa.softtimeout.enable", "true");
+ if ( !enabled)
+ rankProperties.put("vespa.softtimeout.enable", "false");
if (factor != null)
rankProperties.put("vespa.softtimeout.factor", String.valueOf(factor));
if (tailcost != null)
diff --git a/container-search/src/test/java/com/yahoo/fs4/test/QueryTestCase.java b/container-search/src/test/java/com/yahoo/fs4/test/QueryTestCase.java
index e2ce26cb908..e998dd4c966 100644
--- a/container-search/src/test/java/com/yahoo/fs4/test/QueryTestCase.java
+++ b/container-search/src/test/java/com/yahoo/fs4/test/QueryTestCase.java
@@ -82,7 +82,7 @@ public class QueryTestCase {
"&ranking.features.query(foo)=30.3&ranking.features.query(bar)=0" +
"&ranking.properties.property.p1=v1&ranking.properties.property.p2=v2" +
"&pos.ll=S22.4532;W123.9887&pos.radius=3&pos.attribute=place&ranking.freshness=37" +
- "&model.searchPath=7/3&ranking.softtimeout.enable=false");
+ "&model.searchPath=7/3&ranking.softtimeout.enable=true");
query.getRanking().setFreshness(new Freshness("123456"));
query.getRanking().setSorting("+field1 -field2");
query.getRanking().setProfile("two");
@@ -108,7 +108,7 @@ public class QueryTestCase {
"&ranking.features.query(foo)=30.3&ranking.features.query(bar)=0" +
"&ranking.properties.property.p1=v1&ranking.properties.property.p2=v2" +
"&pos.ll=S22.4532;W123.9887&pos.radius=3&pos.attribute=place&ranking.freshness=37" +
- "&model.searchPath=7/3&ranking.softtimeout.enable=false");
+ "&model.searchPath=7/3");
query.getRanking().setFreshness("123456");
query.getRanking().setSorting("+field1 -field2");
query.getRanking().setProfile("two");
@@ -130,7 +130,6 @@ public class QueryTestCase {
@Test
public void testEncodeQueryPacketWithLabelsConnectivityAndSignificance() {
Query query = new Query();
- query.properties().set(SoftTimeout.enableProperty, false);
AndItem and = new AndItem();
WeightedSetItem taggable1 = new WeightedSetItem("field1");
taggable1.setLabel("foo");
diff --git a/container-search/src/test/java/com/yahoo/prelude/fastsearch/test/FastSearcherTestCase.java b/container-search/src/test/java/com/yahoo/prelude/fastsearch/test/FastSearcherTestCase.java
index 44f090b8c51..f4be2943f5f 100644
--- a/container-search/src/test/java/com/yahoo/prelude/fastsearch/test/FastSearcherTestCase.java
+++ b/container-search/src/test/java/com/yahoo/prelude/fastsearch/test/FastSearcherTestCase.java
@@ -171,7 +171,6 @@ public class FastSearcherTestCase {
documentdbConfigWithOneDb);
Query query = new Query("?query=foo&model.restrict=testDb");
- query.getRanking().getSoftTimeout().setEnable(false);
query.prepare();
doSearch(fastSearcher, query, 0, 10);
diff --git a/container-search/src/test/java/com/yahoo/search/query/SoftTimeoutTestCase.java b/container-search/src/test/java/com/yahoo/search/query/SoftTimeoutTestCase.java
index 5026250ab91..0881a141abd 100644
--- a/container-search/src/test/java/com/yahoo/search/query/SoftTimeoutTestCase.java
+++ b/container-search/src/test/java/com/yahoo/search/query/SoftTimeoutTestCase.java
@@ -25,7 +25,7 @@ public class SoftTimeoutTestCase {
assertEquals(Double.valueOf(0.7), query.getRanking().getSoftTimeout().getFactor());
assertEquals(Double.valueOf(0.3), query.getRanking().getSoftTimeout().getTailcost());
query.prepare();
- assertEquals("true", query.getRanking().getProperties().get("vespa.softtimeout.enable").get(0));
+ assertNull(query.getRanking().getProperties().get("vespa.softtimeout.enable"));
assertEquals("0.7", query.getRanking().getProperties().get("vespa.softtimeout.factor").get(0));
assertEquals("0.3", query.getRanking().getProperties().get("vespa.softtimeout.tailcost").get(0));
}
@@ -35,7 +35,7 @@ public class SoftTimeoutTestCase {
Query query=new Query("?query=test&ranking.softtimeout.enable=false");
assertFalse(query.getRanking().getSoftTimeout().getEnable());
query.prepare();
- assertTrue(query.getRanking().getProperties().isEmpty());
+ assertEquals("false", query.getRanking().getProperties().get("vespa.softtimeout.enable").get(0));
}
private void verifyException(String key, String value) {