summaryrefslogtreecommitdiffstats
path: root/container-search
diff options
context:
space:
mode:
authorYngve Aasheim <yngveaasheim@users.noreply.github.com>2021-03-19 08:51:28 +0100
committerGitHub <noreply@github.com>2021-03-19 08:51:28 +0100
commit4210340b1244a1857ef87152d7ef147986d8f667 (patch)
tree51661af22519b752250ed481bfd6961f0b352d49 /container-search
parent87e45838e377c573689ab250abf183b1948f8a21 (diff)
parentda753688b306d1d2d09a21781940dca8d94cb86c (diff)
Merge pull request #16930 from vespa-engine/bratseth/remove-active-queries-metrics
Remove active queries metrics that are never set
Diffstat (limited to 'container-search')
-rw-r--r--container-search/src/main/java/com/yahoo/prelude/statistics/StatisticsSearcher.java13
-rw-r--r--container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java6
2 files changed, 12 insertions, 7 deletions
diff --git a/container-search/src/main/java/com/yahoo/prelude/statistics/StatisticsSearcher.java b/container-search/src/main/java/com/yahoo/prelude/statistics/StatisticsSearcher.java
index 8fc31627800..941015b2fae 100644
--- a/container-search/src/main/java/com/yahoo/prelude/statistics/StatisticsSearcher.java
+++ b/container-search/src/main/java/com/yahoo/prelude/statistics/StatisticsSearcher.java
@@ -57,7 +57,6 @@ public class StatisticsSearcher extends Searcher {
private static final String QUERY_LATENCY_METRIC = "query_latency";
private static final String QUERY_HIT_OFFSET_METRIC = "query_hit_offset";
private static final String QUERIES_METRIC = "queries";
- private static final String ACTIVE_QUERIES_METRIC = "active_queries";
private static final String PEAK_QPS_METRIC = "peak_qps";
private static final String DOCS_COVERED_METRIC = "documents_covered";
private static final String DOCS_TOTAL_METRIC = "documents_total";
@@ -84,12 +83,12 @@ public class StatisticsSearcher extends Searcher {
// Naming of enums are reflected directly in metric dimensions and should not be changed as they are public API
private enum DegradedReason { match_phase, adaptive_timeout, timeout, non_ideal_state }
- private Metric metric;
- private Map<String, Metric.Context> chainContexts = new CopyOnWriteHashMap<>();
- private Map<String, Metric.Context> statePageOnlyContexts = new CopyOnWriteHashMap<>();
- private Map<String, Map<DegradedReason, Metric.Context>> degradedReasonContexts = new CopyOnWriteHashMap<>();
- private Map<String, Map<String, Metric.Context>> relevanceContexts = new CopyOnWriteHashMap<>();
- private java.util.Timer scheduler = new java.util.Timer(true);
+ private final Metric metric;
+ private final Map<String, Metric.Context> chainContexts = new CopyOnWriteHashMap<>();
+ private final Map<String, Metric.Context> statePageOnlyContexts = new CopyOnWriteHashMap<>();
+ private final Map<String, Map<DegradedReason, Metric.Context>> degradedReasonContexts = new CopyOnWriteHashMap<>();
+ private final Map<String, Map<String, Metric.Context>> relevanceContexts = new CopyOnWriteHashMap<>();
+ private final java.util.Timer scheduler = new java.util.Timer(true);
private class PeakQpsReporter extends java.util.TimerTask {
private long prevMaxQPSTime = System.currentTimeMillis();
diff --git a/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java b/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java
index 3f0000367e7..5c97c92e89a 100644
--- a/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java
+++ b/container-search/src/test/java/com/yahoo/search/yql/YqlParserTestCase.java
@@ -123,6 +123,12 @@ public class YqlParserTestCase {
}
@Test
+ public void testHitLimit() {
+ assertParse("select artist_name, track_name, track_uri from sources * where (myField contains ([{\"prefix\":true}]\"m\") and ([{\"hitLimit\": 5000, \"descending\": true}]range(static_score,0,Infinity))) limit 30 offset 0;",
+ "AND myField:m* static_score:[0;;-5000]");
+ }
+
+ @Test
public void test() {
assertParse("select foo from bar where title contains \"madonna\";",
"title:madonna");