Merge pull request #19335 from vespa-engine/hakonhall/fail-hosted-feature-flags-dry-run-if-overrides-for-undefined-flags

Fail hosted-feature-flags dry run if overrides for undefined flags

1 files changed, 3 insertions, 2 deletions

diff --git a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/systemflags/v1/SystemFlagsDataArchive.java b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/systemflags/v1/SystemFlagsDataArchive.java
index 850e14b25e8..367b258e7b6 100644
--- a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/systemflags/v1/SystemFlagsDataArchive.java
+++ b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/systemflags/v1/SystemFlagsDataArchive.java
@@ -23,6 +23,7 @@ import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
@@ -125,9 +126,9 @@ public class SystemFlagsDataArchive {
         uncheck(zipOut::flush);
     }
 
-    public Set<FlagData> flagData(FlagsTarget target) {
+    public List<FlagData> flagData(FlagsTarget target) {
         List<String> filenames = target.flagDataFilesPrioritized();
-        Set<FlagData> targetData = new HashSet<>();
+        List<FlagData> targetData = new ArrayList<>();
         files.forEach((flagId, fileMap) -> {
             for (String filename : filenames) {
                 FlagData data = fileMap.get(filename);