summaryrefslogtreecommitdiffstats
path: root/controller-api
diff options
context:
space:
mode:
authorHarald Musum <musum@verizonmedia.com>2020-03-24 17:29:33 +0100
committerGitHub <noreply@github.com>2020-03-24 17:29:33 +0100
commite2ab3a5b44df89be273df3cf1df49bab8866fcf7 (patch)
tree0b90d66694cafb3e73da8bc854d5960eeeac2123 /controller-api
parent9bd9bff615bcf1f8cb3fb532d0268841894b8efb (diff)
Revert "Allow watchers for issues (#12689)"
This reverts commit 678383db15485b46d5d5b6aa9af57bd33a4cf740.
Diffstat (limited to 'controller-api')
-rw-r--r--controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/IssueHandler.java9
-rw-r--r--controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/MockIssueHandler.java11
2 files changed, 0 insertions, 20 deletions
diff --git a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/IssueHandler.java b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/IssueHandler.java
index a49cee30015..80e23249daa 100644
--- a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/IssueHandler.java
+++ b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/IssueHandler.java
@@ -76,15 +76,6 @@ public interface IssueHandler {
boolean reassign(IssueId issueId, User assignee);
/**
- * Reassign the issue with the given ID to the given user, and returns the outcome of this.
- *
- * @param issueId ID of the issue to be watched.
- * @param watcher watcher to add to the issue.
- * @return Whether adding the watcher was successful.
- */
- boolean addWatcher(IssueId issueId, String watcher);
-
- /**
* Escalate an issue filed with the given property.
*
* @param issueId ID of the issue to escalate.
diff --git a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/MockIssueHandler.java b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/MockIssueHandler.java
index cf0b467c790..deabbcabac8 100644
--- a/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/MockIssueHandler.java
+++ b/controller-api/src/main/java/com/yahoo/vespa/hosted/controller/api/integration/organization/MockIssueHandler.java
@@ -7,7 +7,6 @@ import java.net.URI;
import java.time.Clock;
import java.time.Duration;
import java.time.Instant;
-import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
@@ -84,12 +83,6 @@ public class MockIssueHandler implements IssueHandler {
}
@Override
- public boolean addWatcher(IssueId issueId, String watcher) {
- issues.get(issueId).addWatcher(watcher);
- return true;
- }
-
- @Override
public Optional<User> escalate(IssueId issueId, Contact contact) {
List<List<User>> contacts = getContactUsers(contact);
Optional<User> assignee = assigneeOf(issueId);
@@ -152,21 +145,17 @@ public class MockIssueHandler implements IssueHandler {
private Instant updated;
private boolean open;
private User assignee;
- private List<String> watchers;
private MockIssue(Issue issue) {
this.issue = issue;
this.updated = clock.instant();
this.open = true;
this.assignee = issue.assignee().orElse(null);
- this.watchers = new ArrayList<>();
}
public Issue issue() { return issue; }
public User assignee() { return assignee; }
public boolean isOpen() { return open; }
- public List<String> watchers() { return List.copyOf(watchers); }
- public void addWatcher(String watcher) { watchers.add(watcher); }
}