summaryrefslogtreecommitdiffstats
path: root/controller-server/src/main/java/com/yahoo
diff options
context:
space:
mode:
authorValerij Fredriksen <valerijf@yahooinc.com>2023-04-21 14:43:08 +0200
committerValerij Fredriksen <valerijf@yahooinc.com>2023-04-21 14:43:08 +0200
commit522c7b5dedfc706fb5d4260431f9a8daa722fb31 (patch)
tree3b054f4977b96d9c800b7c806aa73a1ee7cc3183 /controller-server/src/main/java/com/yahoo
parente3286f1470f20af980a982b1331f90e3d841015a (diff)
Code review fixes
Diffstat (limited to 'controller-server/src/main/java/com/yahoo')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java7
1 files changed, 3 insertions, 4 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java
index 29fb095d8b5..d5029d2d8a5 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java
@@ -2050,10 +2050,9 @@ public class ApplicationApiHandler extends AuditLoggingRequestHandler {
else numInitial++;
}
- if ((numInitial > 0 && numNoReport > 0) ||
- (numReadied > 0 && (numNoReport > 0 || numInitial > 0 || numDropped > 0)) ||
- (numStarted > 0 && (numInitial > 0 || numDropped > 0)))
- return ErrorResponse.conflict("Inconsistent state, try restarting drop documents again");
+ if (numInitial + numDropped > 0 && numNoReport + numReadied + numStarted > 0)
+ return ErrorResponse.conflict("Last dropping of documents may have failed to clear all documents due " +
+ "to concurrent topology changes, consider retrying");
Slime slime = new Slime();
Cursor root = slime.setObject();