aboutsummaryrefslogtreecommitdiffstats
path: root/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java
diff options
context:
space:
mode:
authorJon Marius Venstad <venstad@gmail.com>2021-11-07 09:15:20 +0100
committerJon Marius Venstad <venstad@gmail.com>2021-11-07 09:15:20 +0100
commit02e9a93817048989152ce04ae1dde8a92d9a818c (patch)
tree918c37e001993a756d9359a5c7e594520c2c2447 /controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java
parent0dac2ad839529051b01e2ea4c4be53bb7a14fb16 (diff)
Replace session timeout with explicit shutdown
Session timeout causes message bus to reply with timeouts when timeout passes. This works poorly with visitors whose document put acks are delayed until the network layer consumes the documents, which may take longer than the remaining session timeout, which is used as message timeout. Keeping the message timeout fixed, and doing a manual abort of the session instead, when the specified timeout has occurred, almost eliminates the problem. Additionally, acking all outstanding documents upon abortion makes the visitors return in a timely manner, and should take care of the rest of the problem.
Diffstat (limited to 'controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java')
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java1
1 files changed, 1 insertions, 0 deletions
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java
index fd2de2e1c1d..f48658af7e3 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/deployment/ZipBuilderTest.java
@@ -59,4 +59,5 @@ public class ZipBuilderTest {
}
return contents;
}
+
} \ No newline at end of file