Refresh routing policies on deploy (de)activation

Refreshing routing policies and performing the necessary DNS updates are
somewhat time sensitive, especially in manually deployed environments, hence it
makes sense that this should be done as early as possible.

After introducing queuing of name service requests in #9224 it became obvious
that the asynchronous behaviour of `RoutingPolicyMaintainer` is no longer
needed. Because name service requests are now executed asynchronously by
default, we can refresh policies during deployment (de)activation without
worrying about DNS service failures or rate limits.

Benefits of this change:

    - Reduces worst-case DNS propagation time by 5 minutes.

    - We no longer need to update *all* routing policies in the system when
      refreshing policies. This both reduces number of queued name service
      requests and distributes them over a longer duration.

    - Implementation is simplified since the system-wide dimension disappears.

    - Fetching of load balancers from config servers conincides with deployment
      and are thus spread over a longer duration.

1 files changed, 1 insertions, 1 deletions

diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/MetricsReporterTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/MetricsReporterTest.java
index b18c39f4042..58f35c0ac05 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/MetricsReporterTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/MetricsReporterTest.java
@@ -255,7 +255,7 @@ public class MetricsReporterTest {
         reporter.maintain();
         assertEquals("Deployment queues name services requests", 6, metrics.getMetric(MetricsReporter.NAME_SERVICE_REQUESTS_QUEUED).intValue());
 
-        tester.updateDns();
+        tester.flushDnsRequests();
         reporter.maintain();
         assertEquals("Queue consumed", 0, metrics.getMetric(MetricsReporter.NAME_SERVICE_REQUESTS_QUEUED).intValue());
     }