Actually add unit test, and verify deployment spec before storing it

1 files changed, 3 insertions, 1 deletions

diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java
index cb3c84f5bd1..c867b97b544 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java
@@ -90,7 +90,6 @@ import java.util.function.Consumer;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
 import static com.yahoo.vespa.hosted.controller.api.integration.configserver.Node.State.active;
 import static com.yahoo.vespa.hosted.controller.api.integration.configserver.Node.State.reserved;
@@ -443,6 +442,9 @@ public class ApplicationController {
             if (applicationPackage.deploymentSpec().requireInstance(instance).concerns(Environment.prod))
                 application = controller.routing().assignRotations(application, instance);
 
+        // Validate new deployment spec thoroughly before storing it.
+        controller.jobController().deploymentStatus(application.get());
+
         store(application);
         return application;
     }