aboutsummaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorJon Bratseth <bratseth@gmail.com>2021-03-25 14:10:20 +0100
committerJon Bratseth <bratseth@gmail.com>2021-03-25 14:10:20 +0100
commit2880b296ffe9ad9b984e7f018e1128d84633f1ba (patch)
tree33b1d4c7008712d650fc0de925cd1748108bbfdf /controller-server
parent227a66ceaa32f217e89d6e676ccda50f8a5b565e (diff)
Don't catch
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/controller/StatsResponse.java34
1 files changed, 14 insertions, 20 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/controller/StatsResponse.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/controller/StatsResponse.java
index a453ea3ba15..ff5ad00912f 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/controller/StatsResponse.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/controller/StatsResponse.java
@@ -22,27 +22,21 @@ public class StatsResponse extends SlimeJsonResponse {
}
private static Slime toSlime(Controller controller) {
- try {
- Slime slime = new Slime();
- Cursor root = slime.setObject();
- Cursor zonesArray = root.setArray("zones");
- for (ZoneId zone : controller.zoneRegistry().zones().reachable().ids()) {
- NodeRepoStats stats = controller.serviceRegistry().configServer().nodeRepository().getStats(zone);
- if (stats.applicationStats().isEmpty()) continue; // skip empty zones
- Cursor zoneObject = zonesArray.addObject();
- zoneObject.setString("id", zone.toString());
- toSlime(stats.load(), zoneObject.setObject("load"));
- toSlime(stats.activeLoad(), zoneObject.setObject("activeLoad"));
- Cursor applicationsArray = zoneObject.setArray("applications");
- for (var applicationStats : stats.applicationStats())
- toSlime(applicationStats, applicationsArray.addObject());
- }
- return slime;
- }
- catch (Exception e) {
- e.printStackTrace();
- throw e;
+ Slime slime = new Slime();
+ Cursor root = slime.setObject();
+ Cursor zonesArray = root.setArray("zones");
+ for (ZoneId zone : controller.zoneRegistry().zones().reachable().ids()) {
+ NodeRepoStats stats = controller.serviceRegistry().configServer().nodeRepository().getStats(zone);
+ if (stats.applicationStats().isEmpty()) continue; // skip empty zones
+ Cursor zoneObject = zonesArray.addObject();
+ zoneObject.setString("id", zone.toString());
+ toSlime(stats.load(), zoneObject.setObject("load"));
+ toSlime(stats.activeLoad(), zoneObject.setObject("activeLoad"));
+ Cursor applicationsArray = zoneObject.setArray("applications");
+ for (var applicationStats : stats.applicationStats())
+ toSlime(applicationStats, applicationsArray.addObject());
}
+ return slime;
}
private static void toSlime(ApplicationStats stats, Cursor applicationObject) {