diff options
author | Bjørn Christian Seime <bjorncs@verizonmedia.com> | 2020-02-17 12:03:25 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-02-17 12:03:25 +0100 |
commit | 8a4d28d0f50dd6e9bad197d524cefd9dfc594e5c (patch) | |
tree | 11fd04db6bccfba14524d7d656eb7ebff4be1a37 /controller-server | |
parent | 6e69b9c55c8274143beeebf737ded947c3af2bb4 (diff) | |
parent | 6dfad8b7839f30380ab02dc4c965a64cd8406d8e (diff) |
Merge pull request #12216 from vespa-engine/jvenstad/deactivate-for-unknown-instances-too
Deactivate also for unknown instances
Diffstat (limited to 'controller-server')
-rw-r--r-- | controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java index e13f957eb9c..b34192b0cf9 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java @@ -1699,13 +1699,11 @@ public class ApplicationApiHandler extends LoggingRequestHandler { } private HttpResponse deactivate(String tenantName, String applicationName, String instanceName, String environment, String region, HttpRequest request) { - Instance instance = controller.applications().requireInstance(ApplicationId.from(tenantName, applicationName, instanceName)); - + DeploymentId id = new DeploymentId(ApplicationId.from(tenantName, applicationName, instanceName), + ZoneId.from(environment, region)); // Attempt to deactivate application even if the deployment is not known by the controller - DeploymentId deploymentId = new DeploymentId(instance.id(), ZoneId.from(environment, region)); - controller.applications().deactivate(deploymentId.applicationId(), deploymentId.zoneId()); - - return new MessageResponse("Deactivated " + deploymentId); + controller.applications().deactivate(id.applicationId(), id.zoneId()); + return new MessageResponse("Deactivated " + id); } /** Returns test config for indicated job, with production deployments of the default instance. */ |