diff options
author | Jon Bratseth <bratseth@oath.com> | 2018-06-07 16:11:51 +0200 |
---|---|---|
committer | Jon Bratseth <bratseth@oath.com> | 2018-06-07 16:11:51 +0200 |
commit | 3a820570fa3961392119ffbd25b5f5480c1abfd4 (patch) | |
tree | 004c4ab6ad9c1289aa2c4752adf7735c8a55b7a2 /controller-server | |
parent | 58ee04c484f89da0a0043a33c74704d87e6dc8d3 (diff) |
Explain validation overrides
Diffstat (limited to 'controller-server')
2 files changed, 6 insertions, 2 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java index 23cc1d31b06..5c11719a849 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/ApplicationController.java @@ -409,7 +409,8 @@ public class ApplicationController { .collect(Collectors.joining(", ")) + ", but does not include " + (deploymentsToRemove.size() > 1 ? "these zones" : "this zone") + - " in deployment.xml"); + " in deployment.xml. " + + application.get().validationOverrides().toAllowMessage(ValidationId.deploymentRemoval)); LockedApplication applicationWithRemoval = application; for (Deployment deployment : deploymentsToRemove) diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ControllerTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ControllerTest.java index 0de153fc3f9..c24c8693688 100644 --- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ControllerTest.java +++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ControllerTest.java @@ -3,6 +3,7 @@ package com.yahoo.vespa.hosted.controller; import com.yahoo.component.Version; import com.yahoo.config.application.api.ValidationId; +import com.yahoo.config.application.api.ValidationOverrides; import com.yahoo.config.provision.ApplicationId; import com.yahoo.config.provision.ApplicationName; import com.yahoo.config.provision.Environment; @@ -179,7 +180,9 @@ public class ControllerTest { fail("Expected exception due to illegal production deployment removal"); } catch (IllegalArgumentException e) { - assertEquals("deployment-removal: application 'tenant1.app1' is deployed in corp-us-east-1, but does not include this zone in deployment.xml", e.getMessage()); + assertEquals("deployment-removal: application 'tenant1.app1' is deployed in corp-us-east-1, but does not include this zone in deployment.xml. " + + ValidationOverrides.toAllowMessage(ValidationId.deploymentRemoval), + e.getMessage()); } assertNotNull("Zone was not removed", applications.require(app1.id()).deployments().get(productionCorpUsEast1.zone(main).get())); |