Make rotations list in Application immutable

1 files changed, 2 insertions, 2 deletions

diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Application.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Application.java
index 1bae9e0ccd4..d989a9dfbe6 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Application.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/Application.java
@@ -99,7 +99,7 @@ public class Application {
         this.majorVersion = Objects.requireNonNull(majorVersion, "majorVersion cannot be null");
         this.metrics = Objects.requireNonNull(metrics, "metrics cannot be null");
         this.pemDeployKey = pemDeployKey;
-        this.rotations = Objects.requireNonNull(rotations, "rotations cannot be null");
+        this.rotations = List.copyOf(Objects.requireNonNull(rotations, "rotations cannot be null"));
         this.rotationStatus = ImmutableMap.copyOf(Objects.requireNonNull(rotationStatus, "rotationStatus cannot be null"));
     }
 
@@ -197,7 +197,7 @@ public class Application {
 
     /** Returns the global rotation id of this, if present */
     public List<RotationId> rotations() {
-        return Collections.unmodifiableList(rotations);
+        return rotations;
     }
 
     /** Returns the default global endpoints for this in given system */