summaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorJon Marius Venstad <jvenstad@yahoo-inc.com>2019-03-12 20:57:56 +0100
committerJon Marius Venstad <jvenstad@yahoo-inc.com>2019-03-12 20:57:56 +0100
commit402a92c3363783c9605c930351b27522c526f899 (patch)
treeb601df5d3b18bc981bcc88f97e2c4595e12ffba2 /controller-server
parent642d391db285fc97c39ebfa90b5931b114b0e22a (diff)
Just log for now
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReader.java10
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReaderTest.java2
2 files changed, 8 insertions, 4 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReader.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReader.java
index 7576bcae8ee..fc4146bae09 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReader.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReader.java
@@ -11,6 +11,7 @@ import java.nio.file.Path;
import java.util.Arrays;
import java.util.List;
import java.util.function.Predicate;
+import java.util.logging.Logger;
import java.util.zip.ZipEntry;
import java.util.zip.ZipInputStream;
@@ -19,6 +20,8 @@ import java.util.zip.ZipInputStream;
*/
public class ZipStreamReader {
+ private static final Logger log = Logger.getLogger(ZipStreamReader.class.getSimpleName());
+
private final ImmutableList<ZipEntryWithContent> entries;
private final int maxEntrySizeInBytes;
@@ -59,9 +62,10 @@ public class ZipStreamReader {
public List<ZipEntryWithContent> entries() { return entries; }
private static String requireName(String name) {
- IllegalArgumentException e = new IllegalArgumentException("Unexpected non-normalized path found in zip content");
- if (Arrays.asList(name.split("/")).contains("..")) throw e;
- if (!name.equals(Path.of(name).normalize().toString())) throw e;
+ if (Arrays.asList(name.split("/")).contains(".."))
+ log.info("Illegal reverse path in '" + name + "'.");
+ if (!name.equals(Path.of(name).normalize().toString()))
+ log.info("Illegal non-normaliSed path '" + name + "'.");
return name;
}
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReaderTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReaderTest.java
index 92462a67e48..fe5680e2a58 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReaderTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/application/ZipStreamReaderTest.java
@@ -53,7 +53,7 @@ public class ZipStreamReaderTest {
tests.forEach((name, expectException) -> {
try {
new ZipStreamReader(new ByteArrayInputStream(zip(Map.of(name, "foo"))), name::equals, 1024);
- assertFalse("Expected exception for '" + name + "'", expectException);
+ //assertFalse("Expected exception for '" + name + "'", expectException);
} catch (IllegalArgumentException ignored) {
assertTrue("Unexpected exception for '" + name + "'", expectException);
}