summaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorjonmv <venstad@gmail.com>2022-05-23 20:55:37 +0200
committerjonmv <venstad@gmail.com>2022-05-23 20:55:37 +0200
commit5f19e11ab273810811fd418da26bf387f654611f (patch)
tree29a37377b7d0bffaf6b9c4b8c8002309cf3d3f0c /controller-server
parentc0c99c8b1bb47721a7d7b422beaa95c057848b3d (diff)
Let deactivateTester step depend on copyVespaLogs step
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/Step.java2
-rw-r--r--controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java4
2 files changed, 3 insertions, 3 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/Step.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/Step.java
index 379cc9c4f0a..ec4d138c44f 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/Step.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/Step.java
@@ -65,7 +65,7 @@ public enum Step {
deactivateReal(true, deployInitialReal, deployReal, endTests, copyVespaLogs),
/** Deactivate the tester. */
- deactivateTester(true, deployTester, endTests),
+ deactivateTester(true, deployTester, endTests, copyVespaLogs),
/** Report completion to the deployment orchestration machinery. */
report(true, installReal, deactivateReal, deactivateTester);
diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java
index 2eaaaf810a9..b9ced334e5a 100644
--- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java
+++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/JobRunnerTest.java
@@ -168,8 +168,8 @@ public class JobRunnerTest {
outcomes.put(endTests, testFailure);
runner.maintain();
assertTrue(run.get().hasFailed());
- assertEquals(List.of(copyVespaLogs, deactivateTester), run.get().readySteps());
- assertStepsWithStartTime(run.get(), deployTester, deployReal, installTester, installReal, startTests, endTests, copyVespaLogs, deactivateTester);
+ assertEquals(List.of(copyVespaLogs), run.get().readySteps());
+ assertStepsWithStartTime(run.get(), deployTester, deployReal, installTester, installReal, startTests, endTests, copyVespaLogs);
outcomes.put(copyVespaLogs, running);
runner.maintain();