diff options
author | Martin Polden <mpolden@mpolden.no> | 2023-07-05 15:43:32 +0200 |
---|---|---|
committer | Martin Polden <mpolden@mpolden.no> | 2023-07-06 13:56:42 +0200 |
commit | 05803b989353686394eca5c17cefdb2525f2fd1d (patch) | |
tree | 93f55c9e471e008fafbfab7688269cc03c6876c1 /controller-server | |
parent | e5b89c6a148d80cfef77baa52e383b642648e194 (diff) |
EndpointCertificateRequestMetadata -> EndpointCertificateRequest
Diffstat (limited to 'controller-server')
3 files changed, 13 insertions, 13 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/EndpointCertificateMaintainer.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/EndpointCertificateMaintainer.java index e8e48bfccee..dea5d048fc5 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/EndpointCertificateMaintainer.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/maintenance/EndpointCertificateMaintainer.java @@ -14,7 +14,7 @@ import com.yahoo.vespa.hosted.controller.Controller; import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificate; import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateDetails; import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateProvider; -import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateRequestMetadata; +import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateRequest; import com.yahoo.vespa.hosted.controller.certificate.UnassignedCertificate; import com.yahoo.vespa.hosted.controller.api.integration.deployment.JobType; import com.yahoo.vespa.hosted.controller.api.integration.secrets.EndpointSecretManager; @@ -200,7 +200,7 @@ public class EndpointCertificateMaintainer extends ControllerMaintainer { } private void deleteOrReportUnmanagedCertificates() { - List<EndpointCertificateRequestMetadata> requests = endpointCertificateProvider.listCertificates(); + List<EndpointCertificateRequest> requests = endpointCertificateProvider.listCertificates(); List<AssignedCertificate> assignedCertificates = curator.readAssignedCertificates(); List<String> leafRequestIds = assignedCertificates.stream().map(AssignedCertificate::certificate).flatMap(m -> m.leafRequestId().stream()).toList(); @@ -244,7 +244,7 @@ public class EndpointCertificateMaintainer extends ControllerMaintainer { if (Instant.parse(request.createTime()).isBefore(Instant.now().minus(7, ChronoUnit.DAYS))) { log.log(Level.INFO, String.format("Deleting unmaintained certificate with request_id %s and SANs %s", request.requestId(), - request.dnsNames().stream().map(d -> d.dnsName).collect(Collectors.joining(", ")))); + request.dnsNames().stream().map(EndpointCertificateRequest.DnsNameStatus::dnsName).collect(Collectors.joining(", ")))); endpointCertificateProvider.deleteCertificate(request.requestId()); } } diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/certificate/EndpointCertificatesHandler.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/certificate/EndpointCertificatesHandler.java index c25b4e7e369..d1311006cde 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/certificate/EndpointCertificatesHandler.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/certificate/EndpointCertificatesHandler.java @@ -15,7 +15,7 @@ import com.yahoo.vespa.hosted.controller.Controller; import com.yahoo.vespa.hosted.controller.api.integration.ServiceRegistry; import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificate; import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateProvider; -import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateRequestMetadata; +import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateRequest; import com.yahoo.vespa.hosted.controller.application.TenantAndApplicationId; import com.yahoo.vespa.hosted.controller.certificate.AssignedCertificate; import com.yahoo.vespa.hosted.controller.persistence.CuratorDb; @@ -60,19 +60,19 @@ public class EndpointCertificatesHandler extends ThreadedHttpRequestHandler { } public HttpResponse listEndpointCertificates() { - List<EndpointCertificateRequestMetadata> request = endpointCertificateProvider.listCertificates(); + List<EndpointCertificateRequest> request = endpointCertificateProvider.listCertificates(); String requestsWithNames = request.stream() - .map(metadata -> metadata.requestId() + " : " + - String.join(", ", metadata.dnsNames().stream() - .map(dnsNameStatus -> dnsNameStatus.dnsName) - .collect(Collectors.joining(", ")))) - .collect(Collectors.joining("\n")); + .map(r -> r.requestId() + " : " + + String.join(", ", r.dnsNames().stream() + .map(EndpointCertificateRequest.DnsNameStatus::dnsName) + .collect(Collectors.joining(", ")))) + .collect(Collectors.joining("\n")); return new StringResponse(requestsWithNames); } - public StringResponse reRequestEndpointCertificateFor(String instanceId, boolean ignoreExistingMetadata) { + public StringResponse reRequestEndpointCertificateFor(String instanceId, boolean ignoreExisting) { ApplicationId applicationId = ApplicationId.fromFullString(instanceId); if (useRandomizedCert.with(FetchVector.Dimension.APPLICATION_ID, instanceId).value()) { throw new IllegalArgumentException("Cannot re-request certificate. " + instanceId + " is assigned certificate from a pool"); @@ -87,7 +87,7 @@ public class EndpointCertificatesHandler extends ThreadedHttpRequestHandler { EndpointCertificate cert = endpointCertificateProvider.requestCaSignedCertificate( keyPrefix, assignedCertificate.certificate().requestedDnsSans(), - ignoreExistingMetadata ? + ignoreExisting ? Optional.empty() : Optional.of(assignedCertificate.certificate()), algo, useAlternativeProvider); diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/CertificatePoolMaintainerTest.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/CertificatePoolMaintainerTest.java index bfd407c312d..ca4ee5cd4d2 100644 --- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/CertificatePoolMaintainerTest.java +++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/maintenance/CertificatePoolMaintainerTest.java @@ -5,7 +5,7 @@ import com.yahoo.jdisc.test.MockMetric; import com.yahoo.vespa.flags.Flags; import com.yahoo.vespa.hosted.controller.ControllerTester; import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateProviderMock; -import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateRequestMetadata.DnsNameStatus; +import com.yahoo.vespa.hosted.controller.api.integration.certificates.EndpointCertificateRequest.DnsNameStatus; import org.junit.jupiter.api.Test; import java.time.Duration; |