summaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorHarald Musum <musum@yahooinc.com>2022-10-07 09:38:17 +0200
committerHarald Musum <musum@yahooinc.com>2022-10-07 09:38:17 +0200
commit070ea8b7cbad77f396833e25a49a36722579b3a7 (patch)
treedcbb5499ce7bb2425866f4cca2e1d2e76ea9882b /controller-server
parent2a3614ba91eeaa3e0425978345cfcb6a87d30e93 (diff)
Use only error code in log when we get internal server error
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java5
1 files changed, 4 insertions, 1 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
index f0ce17ecacf..c99b85ecf52 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
@@ -238,10 +238,13 @@ public class InternalStepRunner implements StepRunner {
case ACTIVATION_CONFLICT:
case APPLICATION_LOCK_FAILURE:
case CONFIG_NOT_CONVERGED:
- case INTERNAL_SERVER_ERROR:
logger.log("Deployment failed with possibly transient error " + e.code() +
", will retry: " + e.getMessage());
return result;
+ case INTERNAL_SERVER_ERROR:
+ // Log only error code, to avoid exposing internal data in error message
+ logger.log("Deployment failed with possibly transient error " + e.code() + ", will retry");
+ return result;
case LOAD_BALANCER_NOT_READY:
case PARENT_HOST_NOT_READY:
logger.log(e.message()); // Consider splitting these messages in summary and details, on config server.