diff options
author | Jon Marius Venstad <jvenstad@yahoo-inc.com> | 2017-12-12 11:15:04 +0100 |
---|---|---|
committer | Jon Marius Venstad <jvenstad@yahoo-inc.com> | 2017-12-12 11:15:04 +0100 |
commit | bfc81fdad037521df6a5e15473d8d40e1ab05d6d (patch) | |
tree | 6eb841532e044f7b62636d1c679f79230b53da62 /controller-server | |
parent | 969f6c3d336dd1c9a83e90692e4b142200b9913b (diff) |
DeploymentId beautification
Diffstat (limited to 'controller-server')
2 files changed, 8 insertions, 8 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java index 6ae11246fd6..5974833aaf0 100644 --- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java +++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/restapi/application/ApplicationApiHandler.java @@ -425,9 +425,9 @@ public class ApplicationApiHandler extends LoggingRequestHandler { DeploymentId deploymentId = new DeploymentId(application.id(), ZoneId.from(environment, region)); - Deployment deployment = application.deployments().get(deploymentId.zone()); + Deployment deployment = application.deployments().get(deploymentId.zoneId()); if (deployment == null) - throw new NotExistsException(application + " is not deployed in " + deploymentId.zone()); + throw new NotExistsException(application + " is not deployed in " + deploymentId.zoneId()); Slime slime = new Slime(); toSlime(slime.setObject(), deploymentId, deployment, request); @@ -443,7 +443,7 @@ public class ApplicationApiHandler extends LoggingRequestHandler { serviceUrlArray.addString(uri.toString()); } - response.setString("nodes", withPath("/zone/v2/" + deploymentId.zone().environment() + "/" + deploymentId.zone().region() + "/nodes/v2/node/?&recursive=true&application=" + deploymentId.applicationId().tenant() + "." + deploymentId.applicationId().application() + "." + deploymentId.applicationId().instance(), request.getUri()).toString()); + response.setString("nodes", withPath("/zone/v2/" + deploymentId.zoneId().environment() + "/" + deploymentId.zoneId().region() + "/nodes/v2/node/?&recursive=true&application=" + deploymentId.applicationId().tenant() + "." + deploymentId.applicationId().application() + "." + deploymentId.applicationId().instance(), request.getUri()).toString()); controller.getLogServerUrl(deploymentId) .ifPresent(elkUrl -> response.setString("elkUrl", elkUrl.toString())); @@ -452,7 +452,7 @@ public class ApplicationApiHandler extends LoggingRequestHandler { response.setString("version", deployment.version().toFullString()); response.setString("revision", deployment.revision().id()); response.setLong("deployTimeEpochMs", deployment.at().toEpochMilli()); - Duration deploymentTimeToLive = controller.zoneRegistry().getDeploymentTimeToLive(deploymentId.zone()); + Duration deploymentTimeToLive = controller.zoneRegistry().getDeploymentTimeToLive(deploymentId.zoneId()); response.setLong("expiryTimeEpochMs", deployment.at().plus(deploymentTimeToLive).toEpochMilli()); controller.applications().get(deploymentId.applicationId()).flatMap(application -> application.deploymentJobs().projectId()) diff --git a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ZoneRegistryMock.java b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ZoneRegistryMock.java index 206ced18bac..3383654a884 100644 --- a/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ZoneRegistryMock.java +++ b/controller-server/src/test/java/com/yahoo/vespa/hosted/controller/ZoneRegistryMock.java @@ -81,8 +81,8 @@ public class ZoneRegistryMock extends AbstractComponent implements ZoneRegistry @Override public Optional<URI> getLogServerUri(DeploymentId deploymentId) { - return Optional.of(deploymentId.zone()) - .map(z -> URI.create(String.format("http://log.%s.test", deploymentId.zone().value()))); + return Optional.of(deploymentId.zoneId()) + .map(z -> URI.create(String.format("http://log.%s.test", deploymentId.zoneId().value()))); } @Override @@ -97,8 +97,8 @@ public class ZoneRegistryMock extends AbstractComponent implements ZoneRegistry @Override public URI getMonitoringSystemUri(DeploymentId deploymentId) { - return URI.create("http://monitoring-system.test/?environment=" + deploymentId.zone().environment().value() + "®ion=" - + deploymentId.zone().region().value() + "&application=" + deploymentId.applicationId().toShortString()); + return URI.create("http://monitoring-system.test/?environment=" + deploymentId.zoneId().environment().value() + "®ion=" + + deploymentId.zoneId().region().value() + "&application=" + deploymentId.applicationId().toShortString()); } @Override |