summaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorjonmv <venstad@gmail.com>2022-06-09 11:49:45 +0200
committerjonmv <venstad@gmail.com>2022-06-09 11:49:45 +0200
commite884533cbd6199be34eaaf0fb9e0e9b3ccaa51a1 (patch)
tree80368576dad28a7feb70223b10265db1462c5963 /controller-server
parent49ba34e36453b42c8a81fcf525cea043cef6c193 (diff)
Use target version (which is compatible with compiled package) for testers if otherwise incompatible
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java7
1 files changed, 4 insertions, 3 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
index 632eb556444..3105adb2488 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
@@ -409,9 +409,10 @@ public class InternalStepRunner implements StepRunner {
}
private Version testerPlatformVersion(RunId id) {
- return application(id.application()).change().isPinned()
- ? controller.jobController().run(id).get().versions().targetPlatform()
- : controller.readSystemVersion();
+ Version targetPlatform = controller.jobController().run(id).get().versions().targetPlatform();
+ Version systemVersion = controller.readSystemVersion();
+ boolean incompatible = controller.applications().versionCompatibility(id.application()).refuse(targetPlatform, systemVersion);
+ return incompatible || application(id.application()).change().isPinned() ? targetPlatform : systemVersion;
}
private Optional<RunStatus> installTester(RunId id, DualLogger logger) {