summaryrefslogtreecommitdiffstats
path: root/controller-server
diff options
context:
space:
mode:
authorandreer <andreer@verizonmedia.com>2020-02-26 13:02:53 +0100
committerandreer <andreer@verizonmedia.com>2020-02-26 13:02:53 +0100
commit911ce210e0b16881c64e8dccd27536fae4bee1d3 (patch)
tree1063375d7f9cbd30abb1c25f74a2c25bb54acaa8 /controller-server
parentb19abcf85324ea2e8e844fe0f5bd4970a16a6ebe (diff)
no need to compute runstatus
Diffstat (limited to 'controller-server')
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/certificate/EndpointCertificateException.java2
-rw-r--r--controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java6
2 files changed, 3 insertions, 5 deletions
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/certificate/EndpointCertificateException.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/certificate/EndpointCertificateException.java
index eaf80d51770..6099ecbb253 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/certificate/EndpointCertificateException.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/certificate/EndpointCertificateException.java
@@ -15,7 +15,7 @@ public class EndpointCertificateException extends RuntimeException {
this.type = type;
}
- public Type getType() {
+ public Type type() {
return type;
}
diff --git a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
index f82425e743c..927ebca67ec 100644
--- a/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
+++ b/controller-server/src/main/java/com/yahoo/vespa/hosted/controller/deployment/InternalStepRunner.java
@@ -301,16 +301,14 @@ public class InternalStepRunner implements StepRunner {
throw e;
} catch (EndpointCertificateException e) {
- switch (e.getType()) {
+ switch (e.type()) {
case CERT_NOT_AVAILABLE:
// Same as CERTIFICATE_NOT_READY above, only from the controller
- Optional<RunStatus> result = startTime.isBefore(controller.clock().instant().minus(Duration.ofHours(1)))
- ? Optional.of(deploymentFailed) : Optional.empty();
if (startTime.plus(endpointCertificateTimeout).isBefore(controller.clock().instant())) {
logger.log("Deployment failed to find provisioned endpoint certificate after " + endpointCertificateTimeout);
return Optional.of(RunStatus.endpointCertificateTimeout);
}
- return result;
+ return Optional.empty();
default:
throw e; // Should be surfaced / fail deployment
}