diff options
| author | gjoranv <gv@verizonmedia.com> | 2022-06-07 20:47:51 +0200 |
|---|---|---|
| committer | gjoranv <gv@verizonmedia.com> | 2022-06-08 11:45:32 +0200 |
| commit | 361cae9b27154e8449068758da49ec8b5b2adc95 (patch) | |
| tree | 3d9870f307098fab88b5ae57383f56f5c5cae8a2 /docproc | |
| parent | 909dd9174e070070e7596ead1a16fe8d97eee98e (diff) | |
Make Processing class final to ensure safety of protected apis.
Diffstat (limited to 'docproc')
| -rw-r--r-- | docproc/abi-spec.json | 8 | ||||
| -rw-r--r-- | docproc/src/main/java/com/yahoo/docproc/Processing.java | 4 |
2 files changed, 4 insertions, 8 deletions
diff --git a/docproc/abi-spec.json b/docproc/abi-spec.json index 41c76cc3a17..84a31bbbfa2 100644 --- a/docproc/abi-spec.json +++ b/docproc/abi-spec.json @@ -190,13 +190,13 @@ "superClass": "com.yahoo.docproc.impl.ProcessingAccess", "interfaces": [], "attributes": [ - "public" + "public", + "final" ], "methods": [ "public void <init>()", "public static com.yahoo.docproc.Processing of(com.yahoo.document.DocumentOperation)", "public void <init>(java.lang.String, com.yahoo.document.DocumentOperation, com.yahoo.docproc.CallStack)", - "protected void <init>(java.lang.String, java.util.List, com.yahoo.docproc.CallStack, com.yahoo.docproc.impl.ProcessingEndpoint, boolean)", "public static com.yahoo.docproc.Processing createProcessingFromDocumentOperations(java.lang.String, java.util.List, com.yahoo.docproc.CallStack)", "public java.lang.String getServiceName()", "public void setServiceName(java.lang.String)", @@ -206,13 +206,9 @@ "public void setVariable(java.lang.String, java.lang.Object)", "public java.lang.Object removeVariable(java.lang.String)", "public boolean hasVariable(java.lang.String)", - "protected com.yahoo.docproc.impl.ProcessingEndpoint getEndpoint()", - "protected void setEndpoint(com.yahoo.docproc.impl.ProcessingEndpoint)", "public void addDocumentOperation(com.yahoo.document.DocumentOperation)", "public java.util.List getDocumentOperations()", "public com.yahoo.docproc.CallStack callStack()", - "protected void setCallStack(com.yahoo.docproc.CallStack)", - "protected java.util.List getOnceOperationsToBeProcessed()", "public java.lang.String toString()" ], "fields": [] diff --git a/docproc/src/main/java/com/yahoo/docproc/Processing.java b/docproc/src/main/java/com/yahoo/docproc/Processing.java index 7579304c8cb..24eb4f42762 100644 --- a/docproc/src/main/java/com/yahoo/docproc/Processing.java +++ b/docproc/src/main/java/com/yahoo/docproc/Processing.java @@ -19,7 +19,7 @@ import java.util.Map; * * @author bratseth */ -public class Processing extends ProcessingAccess { +public final class Processing extends ProcessingAccess { /** The name of the service which owns this processing. Null is the same as "default". */ private String service = null; @@ -98,7 +98,7 @@ public class Processing extends ProcessingAccess { } @SuppressWarnings({"unused"}) - protected Processing(String service, List<DocumentOperation> documentOpsAndUpdates, CallStack callStack, ProcessingEndpoint endp, boolean unused) { + private Processing(String service, List<DocumentOperation> documentOpsAndUpdates, CallStack callStack, ProcessingEndpoint endp, boolean unused) { this.service = service; this.documentOperations = new ArrayList<>(documentOpsAndUpdates.size()); documentOperations.addAll(documentOpsAndUpdates); |